Skip to content

[Tools]Throw exception if a solution reference a not exist csproj. #15101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented May 25, 2021

Description

Problem want to solve

  1. CI still pass when a referenced csproj file is removed. But this should be detected.

Solution

  1. We will detect the existance of every csproj file referenced by the solution files and throw exception if any of them doesn't exist.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms linked an issue May 25, 2021 that may be closed by this pull request
msJinLei
msJinLei previously approved these changes Jun 9, 2021
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethanyZhou BethanyZhou merged commit 9c6bcf3 into main Jun 18, 2021
@wyunchi-ms wyunchi-ms deleted the wyunchi/fix/CreateFilterMapping branch July 5, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline should check the path of all csproj files
3 participants