Skip to content

Fixed CLU issue with ValidateElement when the object is not a string or enum. #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2015
Merged

Conversation

hovsepm
Copy link
Contributor

@hovsepm hovsepm commented Dec 17, 2015

No description provided.

@markcowl
Copy link
Member

@johanste can you take a look?

@johanste
Copy link
Member

For value types other than enum, we really should pass in the correct (invariant) culture when calling ToString.

Best regards,
Johan

From: Mark Cowlishaw [mailto:[email protected]]
Sent: Thursday, December 17, 2015 1:31 PM
To: Azure/azure-powershell [email protected]
Cc: Johan Stenberg [email protected]
Subject: Re: [azure-powershell] Fixed CLU issue with ValidateElement when the object is not a string or enum. (#1513)

@johanstehttps://github.com/johanste can you take a look?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1513#issuecomment-165586673.

@hovsepm
Copy link
Contributor Author

hovsepm commented Dec 18, 2015

@johanste addressed feedback. Also added version bump up to this PR (actually done by mistake, but I think it can go along with these changes).

@hovsepm
Copy link
Contributor Author

hovsepm commented Dec 18, 2015

now have to bring other changes since the Nuget packages were bumped up.

hovsepm pushed a commit that referenced this pull request Dec 18, 2015
Fixed CLU issue with ValidateElement when the object is not a string or enum.
@hovsepm hovsepm merged commit 651f2f6 into Azure:clu Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants