Skip to content

Monthly release of Azure Networking #15182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

MikhailTryakhov
Copy link
Contributor

Description

Monthly release of Azure Networking

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@msJinLei
Copy link
Contributor

msJinLei commented Jun 6, 2021

/azp run

@msJinLei
Copy link
Contributor

msJinLei commented Jun 6, 2021

@BethanyZhou could you double confirm the change of src/Accounts/Accounts/AzureRmAlias/Mappings.json

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@MikhailTryakhov
Copy link
Contributor Author

Hey @msJinLei looks like breaking change caused our required job failure... Due to it was approved previously so looks like that can be ignored?
Can you please help to summarize any issues we need to work on? Or... merge? :)

@msJinLei
Copy link
Contributor

msJinLei commented Jun 7, 2021

Hey @msJinLei looks like breaking change caused our required job failure... Due to it was approved previously so looks like that can be ignored?
Can you please help to summarize any issues we need to work on? Or... merge? :)

You can suppress the breaking change issues by adding following lines to tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv

D:\a\1\s\artifacts//StaticAnalysisResults\BreakingChangeIssues.csv Errors
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Network","Microsoft.Azure.Commands.Network.AddAzureRmLoadBalancerRuleConfigCommand","Add-AzLoadBalancerRuleConfig","0","2020","The cmdlet 'Add-AzLoadBalancerRuleConfig' no longer supports the type 'System.String' for parameter 'BackendAddressPoolId'.","Change the type for parameter 'BackendAddressPoolId' back to 'System.String'."
"Az.Network","Microsoft.Azure.Commands.Network.AddAzureRmLoadBalancerRuleConfigCommand","Add-AzLoadBalancerRuleConfig","0","2020","The cmdlet 'Add-AzLoadBalancerRuleConfig' no longer supports the type 'Microsoft.Azure.Commands.Network.Models.PSBackendAddressPool' for parameter 'BackendAddressPool'.","Change the type for parameter 'BackendAddressPool' back to 'Microsoft.Azure.Commands.Network.Models.PSBackendAddressPool'."
"Az.Network","Microsoft.Azure.Commands.Network.NewAzureRmLoadBalancerRuleConfigCommand","New-AzLoadBalancerRuleConfig","0","2020","The cmdlet 'New-AzLoadBalancerRuleConfig' no longer supports the type 'System.String' for parameter 'BackendAddressPoolId'.","Change the type for parameter 'BackendAddressPoolId' back to 'System.String'."
"Az.Network","Microsoft.Azure.Commands.Network.NewAzureRmLoadBalancerRuleConfigCommand","New-AzLoadBalancerRuleConfig","0","2020","The cmdlet 'New-AzLoadBalancerRuleConfig' no longer supports the type 'Microsoft.Azure.Commands.Network.Models.PSBackendAddressPool' for parameter 'BackendAddressPool'.","Change the type for parameter 'BackendAddressPool' back to 'Microsoft.Azure.Commands.Network.Models.PSBackendAddressPool'."
"Az.Network","Microsoft.Azure.Commands.Network.SetAzureRmLoadBalancerRuleConfigCommand","Set-AzLoadBalancerRuleConfig","0","2020","The cmdlet 'Set-AzLoadBalancerRuleConfig' no longer supports the type 'System.String' for parameter 'BackendAddressPoolId'.","Change the type for parameter 'BackendAddressPoolId' back to 'System.String'."
"Az.Network","Microsoft.Azure.Commands.Network.SetAzureRmLoadBalancerRuleConfigCommand","Set-AzLoadBalancerRuleConfig","0","2020","The cmdlet 'Set-AzLoadBalancerRuleConfig' no longer supports the type 'Microsoft.Azure.Commands.Network.Models.PSBackendAddressPool' for parameter 'BackendAddressPool'.","Change the type for parameter 'BackendAddressPool' back to 'Microsoft.Azure.Commands.Network.Models.PSBackendAddressPool'."

@msJinLei
Copy link
Contributor

msJinLei commented Jun 8, 2021

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei added this to the S188 (2021-06-15) milestone Jun 8, 2021
@dingmeng-xue dingmeng-xue changed the base branch from master to dixue/release June 8, 2021 07:38
@dingmeng-xue dingmeng-xue changed the base branch from dixue/release to master June 8, 2021 07:40
@msJinLei
Copy link
Contributor

msJinLei commented Jun 8, 2021

all changes move to #15207

@MikhailTryakhov
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@MikhailTryakhov
Copy link
Contributor Author

@msJinLei can you please review/merge it?

@msJinLei
Copy link
Contributor

msJinLei commented Jun 9, 2021

@msJinLei can you please review/merge it?

@dingmeng-xue has created another PR #15207 to merge Network-February to master and it is merged.
We are closing this PR now.

@MikhailTryakhov
Copy link
Contributor Author

thank you! nice to hear that! CLosing in this case

@MikhailTryakhov MikhailTryakhov deleted the mitryakh/02-01 branch June 9, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants