Skip to content

[SQL] Fix AutoRotationEnabled param #15247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2021
Merged

Conversation

viparek
Copy link
Contributor

@viparek viparek commented Jun 10, 2021

Description

This PR has a fix for the AzSqlManagedInstanceTransparentDataEncryptionProtector cmdlet. The param '--AutoRotationEnabled' was wrongly set to be of type SwitchParameter instead of a bool.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou added the Breaking Change Release This PR contains breaking change label Jun 11, 2021
@BethanyZhou
Copy link
Contributor

BethanyZhou commented Jun 11, 2021

Hi @viparek ,

  • Some issues were identified after you raise the problem which current PR is trying to fix, please raise another PR to fix the two items below first.
    • As you said in changelog.md, AutoRotationEnabled were added into 4 cmdlets. But I only find AutoRotationEnabled in Set-AzSqlServerTransparentDataEncryptionProtector and Set-AzSqlInstanceTransparentDataEncryptionProtector, please have a look.
      * Added -AutoRotationEnabled parameter to following cmdlets:    
      - `Set-AzSqlServerTransparentDataEncryptionProtector`    
      - `Get-AzSqlServerTransparentDataEncryptionProtector`    
      - `Set-AzSqlInstanceTransparentDataEncryptionProtector`    
      - `Get-AzSqlInstanceTransparentDataEncryptionProtector`
      
    • The syntaxes of cmdlets above have not updated yet, please update changed cmdlets' help docs by following steps: https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/help-generation.md#updating-help-after-making-cmdlet-changes.
  • For this pr:
    • Please add your change log msg on the top of upcoming release section.
    • Please wait for the end of our regular release. Current is our code freeze time. After we finish our regular release, your change will cause a breaking change. A breaking change suppression will need be done.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Jun 18, 2021

Hi @viparek , please suppress the breaking change errors in "tools/StaticAnalysis/Exceptions/${ModuleName}/BreakingChangeIssues.csv"
for example:
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Sql","Microsoft.Azure.Commands.Sql.TransparentDataEncryption.Cmdlet.SetAzureRmSqlManagedInstanceTransparentDataEncryptionProtector","Set-AzSqlInstanceTransparentDataEncryptionProtector","0","2020","The cmdlet 'Set-AzSqlInstanceTransparentDataEncryptionProtector' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'AutoRotationEnabled'.","Change the type for parameter 'AutoRotationEnabled' back to 'System.Management.Automation.SwitchParameter'."
"

@BethanyZhou BethanyZhou merged commit 585b83c into Azure:main Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change Waiting for CI :shipit:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants