Skip to content

Fix #15091- Import-AzWebAppKeyVaultCertificate api version bug #15281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 21, 2021
Merged

Fix #15091- Import-AzWebAppKeyVaultCertificate api version bug #15281

merged 6 commits into from
Jun 21, 2021

Conversation

Kotasudhakarreddy
Copy link
Contributor

#15091

Description

When running the Import-AzWebAppKeyVaultCertificate command using the latest CLI and using a full pathed version of the keyvault "as its in a different subscription level", it returns the following response.

"The api-version '2016-10-01' is invalid. The supported versions are
'2021-04-01,2021-01-01,2020-10-01,2020-09-01,2020-08-01,2020-07-01,2020-06-01,2020-05-01,2020-01-01,2019-11-01,2019-10-
01,2019-09-01,2019-08-01,2019-07-01,2019-06-01,2019-05-10,2019-05-01,2019-03-01,2018-11-01,2018-09-01,2018-08-01,2018-0
7-01,2018-06-01,2018-05-01,2018-02-01,2018-01-01,2017-12-01,2017-08-01,2017-06-01,2017-05-10,2017-05-01,2017-03-01,2016
-09-01,2016-07-01,2016-06-01,2016-02-01,2015-11-01,2015-01-01,2014-04-01-preview,2014-04-01,2014-01-01,2013-03-01,2014-
02-26,2014-04'

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue
Copy link
Member

Azure PowerShell doesn't allow to depends on other service's management SDK because the limitation of assembly loading .NET core. Please share which operation of keyvault you need. Technically, we should upgrade common lib to support new version.

@Kotasudhakarreddy
Copy link
Contributor Author

Azure PowerShell doesn't allow to depends on other service's management SDK because the limitation of assembly loading .NET core. Please share which operation of keyvault you need. Technically, we should upgrade common lib to support new version.

I Need to make use KeyVault GET call. Yes, technically we should use common lib but the earlier version of code is used the specific version lib i.e. Microsoft.Azure.Commands.Common.KeyVault.Version2016_10_1. Now I have replaced everything with the common lib.

@isra-fel
Copy link
Member

Hey, let's put this PR on hold until the discussion in #15091 reaches an agreement.

@Kotasudhakarreddy
Copy link
Contributor Author

Hey, let's put this PR on hold until the discussion in #15091 reaches an agreem

AKV SDK changes are rolled back. please review.

@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethanyZhou BethanyZhou merged commit 65a2037 into Azure:main Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants