[Storage] Support container softdelete #15284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueww
force-pushed
the
containersoftdeletega
branch
from
fa70f61 to
24e6c72
Compare
BethanyZhou
reviewed
Jun 17, 2021
There was a problem hiding this comment.
Hi @blueww , please submit a cmdlet design for new added cmdlets.
For Enable-AzStorageContainerDeleteRetentionPolicy and Disable-AzStorageContainerDeleteRetentionPolicy,
I suggest we combine them as one cmdlet, for instance Update-AzStorageContainer [DeleteRetentionPolicy <switch>].
Comment on lines
784
to
812
| $stos = Get-AzStorageAccount -ResourceGroupName $rgname; | ||
|
|
||
| # Enable Blob Delete Retention Policy | ||
| $policy = Enable-AzStorageContainerDeleteRetentionPolicy -ResourceGroupName $rgname -StorageAccountName $stoname -PassThru -RetentionDays 30 | ||
| Assert-AreEqual $true $policy.Enabled | ||
| Assert-AreEqual 30 $policy.Days | ||
| $property = Get-AzStorageBlobServiceProperty -ResourceGroupName $rgname -StorageAccountName $stoname | ||
| Assert-AreEqual $true $property.ContainerDeleteRetentionPolicy.Enabled | ||
| Assert-AreEqual 30 $property.ContainerDeleteRetentionPolicy.Days | ||
|
|
||
| # Create and delete container, then get container | ||
| $contaierName = "testcontaienr" | ||
| New-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -Name $contaierName | ||
| Remove-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -Name $contaierName -Force | ||
| $cons = Get-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname | ||
| Assert-AreEqual 0 $cons.Count | ||
| $cons = Get-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -IncludeDeleted | ||
| Assert-AreEqual 1 $cons.Count | ||
| Assert-AreEqual $contaierName $cons[0].Name | ||
| Assert-AreEqual $true $cons[0].Deleted | ||
|
|
||
|
|
||
| # Disable Blob Delete Retention Policy | ||
| $policy = Disable-AzStorageContainerDeleteRetentionPolicy -ResourceGroupName $rgname -StorageAccountName $stoname -PassThru | ||
| Assert-AreEqual $false $policy.Enabled | ||
| $property = Get-AzStorageBlobServiceProperty -ResourceGroupName $rgname -StorageAccountName $stoname | ||
| Assert-AreEqual $false $property.ContainerDeleteRetentionPolicy.Enabled | ||
|
|
||
| Remove-AzStorageAccount -Force -ResourceGroupName $rgname -Name $stoname; |
There was a problem hiding this comment.
HI @blueww , please correct indents.
| $containerNamesoftdelete = "softdeletecontainer" | ||
| New-AzStorageContainer -Name $containerNamesoftdelete -Context $storageContext | ||
| Remove-AzStorageContainer -Name $containerNamesoftdelete -Context $storageContext -Force | ||
| ## Get container without -IncludeDeleted, won't list out deleted containers |
There was a problem hiding this comment.
Please correct indents.
|
For Enable-AzStorageContainerDeleteRetentionPolicy and Disable-AzStorageContainerDeleteRetentionPolicy, they are alredy in https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/726.
|
|
Make sense. |
blueww
force-pushed
the
containersoftdeletega
branch
from
9d23e5f to
d427562
Compare
BethanyZhou
approved these changes
Jun 17, 2021
|
/azp run azure-powershell - windows-powershell |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
design pass review in: Azure/azure-powershell-cmdlet-review-pr#726
Add a static analysis exception for -RetentionDays. This is already discussed in design review and the name agreed.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added