Skip to content

Sync DiskPool from generation to main (Get-AzDiskPoolOutboundNetworkDependencyEndpoint, Get-AzDiskPoolZone and output table format) #15286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 36 additions & 6 deletions src/DiskPool/Az.DiskPool.format.ps1xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,27 +82,39 @@
</ViewSelectedBy>
<TableControl>
<TableHeaders>
<TableColumnHeader>
<Label>Name</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>Location</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>Name</Label>
<Label>Status</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>Type</Label>
<Label>ProvisioningState</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>AvailabilityZone</Label>
</TableColumnHeader>
</TableHeaders>
<TableRowEntries>
<TableRowEntry>
<TableColumnItems>
<TableColumnItem>
<PropertyName>Name</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>Location</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>Name</PropertyName>
<PropertyName>Status</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>Type</PropertyName>
<PropertyName>ProvisioningState</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>AvailabilityZone</PropertyName>
</TableColumnItem>
</TableColumnItems>
</TableRowEntry>
Expand Down Expand Up @@ -297,21 +309,33 @@
<TableControl>
<TableHeaders>
<TableColumnHeader>
<Label>AdditionalCapability</Label>
<Label>SkuName</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>SkuTier</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>AvailabilityZone</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>AdditionalCapability</Label>
</TableColumnHeader>
</TableHeaders>
<TableRowEntries>
<TableRowEntry>
<TableColumnItems>
<TableColumnItem>
<PropertyName>AdditionalCapability</PropertyName>
<PropertyName>SkuName</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>SkuTier</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>AvailabilityZone</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>AdditionalCapability</PropertyName>
</TableColumnItem>
</TableColumnItems>
</TableRowEntry>
</TableRowEntries>
Expand Down Expand Up @@ -687,13 +711,19 @@
<TableColumnHeader>
<Label>Category</Label>
</TableColumnHeader>
<TableColumnHeader>
<Label>Endpoint</Label>
</TableColumnHeader>
</TableHeaders>
<TableRowEntries>
<TableRowEntry>
<TableColumnItems>
<TableColumnItem>
<PropertyName>Category</PropertyName>
</TableColumnItem>
<TableColumnItem>
<PropertyName>Endpoint</PropertyName>
</TableColumnItem>
</TableColumnItems>
</TableRowEntry>
</TableRowEntries>
Expand Down
16 changes: 9 additions & 7 deletions src/DiskPool/Az.DiskPool.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# Generated by: Microsoft Corporation
#
# Generated on: 6/7/2021
# Generated on: 6/16/2021
#

@{
Expand Down Expand Up @@ -69,11 +69,13 @@ FormatsToProcess = './Az.DiskPool.format.ps1xml'
# NestedModules = @()

# Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
FunctionsToExport = 'Get-AzDiskPool', 'Get-AzDiskPoolIscsiTarget', 'New-AzDiskPool',
'New-AzDiskPoolAclObject', 'New-AzDiskPoolIscsiLunObject',
'New-AzDiskPoolIscsiTarget', 'Remove-AzDiskPool',
'Remove-AzDiskPoolIscsiTarget', 'Start-AzDiskPool', 'Stop-AzDiskPool',
'Update-AzDiskPool', 'Update-AzDiskPoolIscsiTarget'
FunctionsToExport = 'Get-AzDiskPool', 'Get-AzDiskPoolIscsiTarget',
'Get-AzDiskPoolOutboundNetworkDependencyEndpoint',
'Get-AzDiskPoolZone', 'New-AzDiskPool', 'New-AzDiskPoolAclObject',
'New-AzDiskPoolIscsiLunObject', 'New-AzDiskPoolIscsiTarget',
'Remove-AzDiskPool', 'Remove-AzDiskPoolIscsiTarget',
'Start-AzDiskPool', 'Stop-AzDiskPool', 'Update-AzDiskPool',
'Update-AzDiskPoolIscsiTarget'

# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
CmdletsToExport = @()
Expand Down Expand Up @@ -111,7 +113,7 @@ PrivateData = @{
# IconUri = ''

# ReleaseNotes of this module
ReleaseNotes = '* Hotfix for the issue on windows powershell'
# ReleaseNotes = ''

# Prerelease string of this module
# Prerelease = ''
Expand Down
2 changes: 2 additions & 0 deletions src/DiskPool/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
- Additional information about change #1
-->
## Upcoming Release
* Added additional info in the output table of New/Update/Remove-Az.DiskPool [#15236]
* Added cmdlet Get-AzDiskPoolOutboundNetworkDependencyEndpoint and Get-AzDiskPoolZone [#15237]

## Version 0.1.1
* Hotfix for the issue on windows powershell
Expand Down
5 changes: 4 additions & 1 deletion src/DiskPool/build-module.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ $null = New-Item -ItemType Directory -Force -Path $examplesFolder

Write-Host -ForegroundColor Green 'Creating cmdlets for specified models...'
$modelCmdlets = @('Acl', 'IscsiLun')
pwsh (Join-Path $PSScriptRoot 'create-model-cmdlets.ps1') -Models $modelCmdlets
if ($modelCmdlets.Count -gt 0) {
. (Join-Path $PSScriptRoot 'create-model-cmdlets.ps1')
CreateModelCmdlet($modelCmdlets)
}

if($NoDocs) {
Write-Host -ForegroundColor Green 'Creating exports...'
Expand Down
Loading