[Cognitive Services] Upgrade to 2021-04-30

[yangyuan]

Description

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • {Please put the link here}
  • the markdown help files have been regenerated using the commands listed here

[yangyuan]

Previously there was a PR but targeted master instead of main.
#15133

Resolved all comments except for SDK caused breaking changes, which include:

• 1 bug fix. ActionRequired -> ActionsRequired, the name was wrong in previous SDKs, thus can never be used.
• 1 string-enum to string type change on a un-used field, its always null. SkuTier-> string
• 1 type name change on a read only field. Only type name change, everything else is same, including field name. IdentityType -> ResourceIdentityType

I tried everything I know of include automapper, but CI still complains type name difference.
I am wondering if we can make an exception for this PR (as impact is very limited), otherwise, I might have to copy the SDK code and modify it to make it compatible with old SDK.

[BethanyZhou]

Hi @yangyuan , main is the new name of master. If you have merged this PR, please check whether your change has been included in main branch.

 "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Az.CognitiveServices","Microsoft.Azure.Commands.Management.CognitiveServices.GetAzureCognitiveServicesAccountCommand","Get-AzCognitiveServicesAccount","0","3030","The generic type for 'property Type' has been changed from 'System.Nullable`1[Microsoft.Azure.Management.CognitiveServices.Models.IdentityType]' to 'System.Nullable`1[Microsoft.Azure.Management.CognitiveServices.Models.ResourceIdentityType]'. ","Change the generic type for 'property Type' back to 'System.Nullable`1[Microsoft.Azure.Management.CognitiveServices.Models.IdentityType]'."
  "Az.CognitiveServices","Microsoft.Azure.Commands.Management.CognitiveServices.GetAzureCognitiveServicesAccountCommand","Get-AzCognitiveServicesAccount","0","3000","The type of property 'Tier' of type 'Microsoft.Azure.Management.CognitiveServices.Models.Sku' has changed from 'System.Nullable`1[Microsoft.Azure.Management.CognitiveServices.Models.SkuTier]' to 'System.String'.","Change the type of property 'Tier' back to 'System.Nullable`1[Microsoft.Azure.Management.CognitiveServices.Models.SkuTier]'."
  "Az.CognitiveServices","Microsoft.Azure.Commands.Management.CognitiveServices.GetAzureCognitiveServicesAccountCommand","Get-AzCognitiveServicesAccount","0","3010","The property 'ActionRequired' of type 'Microsoft.Azure.Management.CognitiveServices.Models.PrivateLinkServiceConnectionState' has been removed.","Add the property 'ActionRequired' back to type 'Microsoft.Azure.Management.CognitiveServices.Models.PrivateLinkServiceConnectionState'."  

Per my knowledge, the first two are no way to avoid. for the last one can resolved by automapper.

As you claim the impact is very limited, please contact our PM and manager to get approval.

[yangyuan]

Hi @BethanyZhou, I sent an email to you about this PR (not sure if I sent to the right alias, let me know if you didn't receive any email)
I dont know who (PM and manager) should be contacted for this, please help to reroute the email or share contact info.

Thanks

[BethanyZhou]

Hi @BethanyZhou Beisi Zhou FTE, I sent an email to you about this PR (not sure if I sent to the right alias, let me know if you didn't receive any email)
I dont know who (PM and manager) should be contacted for this, please help to reroute the email or share contact info.

Thanks

I didn't receive this email, please contact [email protected]. It's our team email.

[yangyuan]

Hi @BethanyZhou, as talked with email. Damien and Dingmeng agreed the change as long as with clear message to customers will be added the changelog..
And I've modified the change log to includes 3 changes with [breaking changes] prefix.

[BethanyZhou]

Hi please see pipeline azure-powershell - powershell-core (Analyze windows) and suppress the breaking changes that were detected by that pipeline. The way to suppress breaking change: https://github.com/Azure/azure-powershell-pr/wiki/How-to-Release-a-Breaking-Change

[yangyuan]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[yangyuan]

@BethanyZhou I ran /azp run and triggered this, all pass.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=980526&view=results

But github still shows Waiting for status to be reported, I guess sth wrong in pipeline.

[BethanyZhou]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[BethanyZhou]

Hi @yangyuan , approved, will force merge this PR to main branch. The feature will be available in next release.