[Synapse] - Enhance existing cmdlets to support the next generation of SQL pool (so called Gen3 or v3)

src/Synapse/Synapse.Test/ScenarioTests/DataClassificationTests.ps1

@@ -205,7 +205,7 @@ function Remove-DataClassificationTestEnvironment ($testSuffix)
 .SYNOPSIS
 Creates the test environment needed to perform the tests
 #>
-function Create-SqlDataClassificationTestEnvironment ($testSuffix, $location = "West Central US")
+function Create-SqlDataClassificationTestEnvironment ($testSuffix, $location = "canadacentral")
 {
 	$params = Get-DataClassificationTestEnvironmentParameters $testSuffix
 

src/Synapse/Synapse.Test/ScenarioTests/FirewallTests.ps1

@@ -87,7 +87,7 @@ function Get-FirewallRuleTestEnvironmentParameters ($testSuffix)
 			  fileSystemName = "fwcmdletfs" + $testSuffix;
 			  loginName = "testlogin";
 			  pwd = "testp@ssMakingIt1007Longer";
-              location = "westcentralus";
+              location = "canadacentral";
 		}
 }
 

src/Synapse/Synapse.Test/ScenarioTests/IntegrationRuntimeTests.ps1

@@ -162,7 +162,7 @@ function Get-WorkspaceTestEnvironmentParameters ($testSuffix)
 			  fileSystemName = "wscmdletfs" + $testSuffix;
 			  loginName = "testlogin";
 			  pwd = "testp@ssMakingIt1007Longer";
-              location = "westcentralus";
+              location = "canadacentral";
 		}
 }
 

src/Synapse/Synapse.Test/ScenarioTests/SparkPoolTests.ps1

@@ -172,7 +172,7 @@ function Get-WorkspaceTestEnvironmentParameters ($testSuffix)
 			  fileSystemName = "wscmdletfs" + $testSuffix;
 			  loginName = "testlogin";
 			  pwd = "testp@ssMakingIt1007Longer";
-              location = "westcentralus";
+              location = "canadacentral";
               sparkPoolName = "spool" + $testSuffix;
 		}
 }

src/Synapse/Synapse.Test/ScenarioTests/SqlDatabaseTests.cs

@@ -32,24 +32,9 @@ public SqlDatabaseTests(Xunit.Abstractions.ITestOutputHelper output)
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestSynapseSqlDatabase()
         {
-            string testResourceGroupName = SynapseTestBase.TestResourceGroupName;
-            if (string.IsNullOrEmpty(testResourceGroupName))
-            {
-                testResourceGroupName = nameof(TestResourceGroupName);
-            }
-
-            string testWorkspaceName = SynapseTestBase.TestWorkspaceName;
-            if (string.IsNullOrEmpty(testWorkspaceName))
-            {
-                testWorkspaceName = nameof(TestWorkspaceName);
-            }
-
             SynapseTestBase.NewInstance.RunPsTest(
                 _logger,
-                string.Format(
-                "Test-SynapseSqlDatabase -resourceGroupName '{0}' -workspaceName '{1}'",
-                testResourceGroupName,
-                testWorkspaceName));
+                "Test-SynapseSqlDatabase");
         }
     }
 }

src/Synapse/Synapse.Test/ScenarioTests/SqlDatabaseTests.ps1

@@ -4,19 +4,18 @@ Tests Synapse SqlDatabase Lifecycle (Create, Update, Get, List, Delete).
 #>
 function Test-SynapseSqlDatabase
 {
-    param
-    (
-        $resourceGroupName = (Get-ResourceGroupName),
-        $workspaceName = (Get-SynapseWorkspaceName),
-        $SqlDatabaseName = (Get-SynapseSqlDatabaseName)
-    )
+	# Setup
+	$testSuffix = getAssetName
+	Create-SqlPoolV3TestEnvironment $testSuffix
+	$params = Get-SqlPoolV3TestEnvironmentParameters $testSuffix
+
 
     try
     {
-        $resourceGroupName = [Microsoft.Azure.Test.HttpRecorder.HttpMockServer]::GetVariable("resourceGroupName", $resourceGroupName)
-        $workspaceName = [Microsoft.Azure.Test.HttpRecorder.HttpMockServer]::GetVariable("workspaceName", $workspaceName)
-        $workspace = Get-AzSynapseWorkspace -resourceGroupName $resourceGroupName -Name $workspaceName
-        $location = $workspace.Location
+        $resourceGroupName = $params.rgname
+        $workspaceName = $params.WorkspaceName
+        $location = $params.location
+        $sqlDatabaseName = $params.sqlDatabaseName
 
         # Test to make sure the SqlDatabase doesn't exist
         Assert-False {Test-AzSynapseSqlDatabase -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -Name $SqlDatabaseName}
@@ -67,7 +66,44 @@ function Test-SynapseSqlDatabase
     }
     finally
     {
-        # cleanup the SQL pool that was used in case it still exists. This is a best effort task, we ignore failures here.
-        Invoke-HandledCmdlet -Command {Remove-AzSynapseSqlDatabase -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -Name $SqlDatabaseName -ErrorAction SilentlyContinue -Force} -IgnoreFailures
+		# Cleanup
+		Remove-SqlPoolV3TestEnvironment $testSuffix
     }
 }
+
+<#
+.SYNOPSIS
+Creates the test environment needed to perform the tests
+#>
+function Create-SqlPoolV3TestEnvironment ($testSuffix)
+{
+	$params = Get-SqlPoolV3TestEnvironmentParameters $testSuffix
+	Create-TestEnvironmentWithParams $params $params.location
+}
+
+<#
+.SYNOPSIS
+Gets the values of the parameters used at the tests
+#>
+function Get-SqlPoolV3TestEnvironmentParameters ($testSuffix)
+{
+	return @{ rgname = "sql-cmdlet-test-rg" +$testSuffix;
+			  workspaceName = "sqlws" +$testSuffix;
+			  sqlDatabaseName = "sqldb" + $testSuffix;
+			  storageAccountName = "sqlstorage" + $testSuffix;
+			  fileSystemName = "sqlcmdletfs" + $testSuffix;
+			  loginName = "testlogin";
+			  pwd = "testp@ssMakingIt1007Longer";
+              location = "eastus2euap";
+		}
+}
+
+<#
+.SYNOPSIS
+Removes the test environment that was needed to perform the tests
+#>
+function Remove-SqlPoolV3TestEnvironment ($testSuffix)
+{
+	$params = Get-SqlPoolV3TestEnvironmentParameters $testSuffix
+	Remove-AzResourceGroup -Name $params.rgname -Force
+}

src/Synapse/Synapse.Test/ScenarioTests/SqlPoolTests.ps1

@@ -207,7 +207,7 @@ function Get-SqlPoolTestEnvironmentParameters ($testSuffix)
 			  loginName = "testlogin";
 			  pwd = "testp@ssMakingIt1007Longer";
 			  perfLevel = 'DW200c';
-              location = "westcentralus";
+              location = "canadacentral";
 		}
 }
 

src/Synapse/Synapse.Test/ScenarioTests/SqlPoolV3Tests.cs

@@ -32,24 +32,9 @@ public SqlPoolV3Tests(Xunit.Abstractions.ITestOutputHelper output)
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestSynapseSqlPoolV3()
         {
-            string testResourceGroupName = SynapseTestBase.TestResourceGroupName;
-            if (string.IsNullOrEmpty(testResourceGroupName))
-            {
-                testResourceGroupName = nameof(TestResourceGroupName);
-            }
-
-            string testWorkspaceName = SynapseTestBase.TestWorkspaceName;
-            if (string.IsNullOrEmpty(testWorkspaceName))
-            {
-                testWorkspaceName = nameof(TestWorkspaceName);
-            }
-
             SynapseTestBase.NewInstance.RunPsTest(
                 _logger,
-                string.Format(
-                "Test-SynapseSqlPoolV3 -resourceGroupName '{0}' -workspaceName '{1}'",
-                testResourceGroupName,
-                testWorkspaceName));
+                "Test-SynapseSqlPoolV3");
         }
     }
 }

src/Synapse/Synapse.Test/ScenarioTests/SqlPoolV3Tests.ps1

@@ -4,20 +4,18 @@ Tests Synapse SqlPool Lifecycle (Create, Update, Get, List, Delete).
 #>
 function Test-SynapseSqlPoolV3
 {
-    param
-    (
-        $resourceGroupName = (Get-ResourceGroupName),
-        $workspaceName = (Get-SynapseWorkspaceName),
-        $sqlPoolName = (Get-SynapseSqlPoolName),
-        $sqlPoolPerformanceLevel = 'DW500f'
-    )
+	# Setup
+	$testSuffix = getAssetName
+	Create-SqlPoolV3TestEnvironment $testSuffix
+	$params = Get-SqlPoolV3TestEnvironmentParameters $testSuffix
 
     try
     {
-        $resourceGroupName = [Microsoft.Azure.Test.HttpRecorder.HttpMockServer]::GetVariable("resourceGroupName", $resourceGroupName)
-        $workspaceName = [Microsoft.Azure.Test.HttpRecorder.HttpMockServer]::GetVariable("workspaceName", $workspaceName)
-        $workspace = Get-AzSynapseWorkspace -resourceGroupName $resourceGroupName -Name $workspaceName
-        $location = $workspace.Location
+        $resourceGroupName = $params.rgname
+        $workspaceName = $params.WorkspaceName
+        $location = $params.location
+        $sqlPoolName = $params.sqlPoolName
+        $sqlPoolPerformanceLevel = 'DW500f'
 
         # Test to make sure the SqlPool doesn't exist
         Assert-False {Test-AzSynapseSqlPool -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -Name $sqlPoolName -Version 3}
@@ -85,6 +83,16 @@ function Test-SynapseSqlPoolV3
         }
         Assert-True {$found -eq 1} "SqlPool created earlier is not found when listing all in resource group: $resourceGroupName."
 
+        # Suspend SqlPool
+        $sqlPoolSuspended = Suspend-AzSynapseSqlPool -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -Name $sqlPoolName -Version 3
+
+        Assert-AreEqual "Paused" $sqlPoolSuspended.Status
+
+        # Resume SqlPool
+        $sqlPoolResumed = Resume-AzSynapseSqlPool -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -Name $sqlPoolName -Version 3
+
+        Assert-AreEqual "Online" $sqlPoolResumed.Status
+
         # Delete SqlPool
         Assert-True {Remove-AzSynapseSqlPool -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -Name $sqlPoolName -Version 3 -PassThru -Force} "Remove SqlPool failed."
 
@@ -95,7 +103,44 @@ function Test-SynapseSqlPoolV3
     }
     finally
     {
-        # cleanup the SQL pool that was used in case it still exists. This is a best effort task, we ignore failures here.
-        Invoke-HandledCmdlet -Command {Remove-AzSynapseSqlPool -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -Name $sqlPoolName -Version 3 -ErrorAction SilentlyContinue -Force} -IgnoreFailures
+		# Cleanup
+		Remove-SqlPoolV3TestEnvironment $testSuffix
     }
 }
+
+<#
+.SYNOPSIS
+Creates the test environment needed to perform the tests
+#>
+function Create-SqlPoolV3TestEnvironment ($testSuffix)
+{
+	$params = Get-SqlPoolV3TestEnvironmentParameters $testSuffix
+	Create-TestEnvironmentWithParams $params $params.location
+}
+
+<#
+.SYNOPSIS
+Gets the values of the parameters used at the tests
+#>
+function Get-SqlPoolV3TestEnvironmentParameters ($testSuffix)
+{
+	return @{ rgname = "sql-cmdlet-test-rg" +$testSuffix;
+			  workspaceName = "sqlws" +$testSuffix;
+			  sqlPoolName = "sqlpoolv3" + $testSuffix;
+			  storageAccountName = "sqlstorage" + $testSuffix;
+			  fileSystemName = "sqlcmdletfs" + $testSuffix;
+			  loginName = "testlogin";
+			  pwd = "testp@ssMakingIt1007Longer";
+              location = "eastus2euap";
+		}
+}
+
+<#
+.SYNOPSIS
+Removes the test environment that was needed to perform the tests
+#>
+function Remove-SqlPoolV3TestEnvironment ($testSuffix)
+{
+	$params = Get-SqlPoolV3TestEnvironmentParameters $testSuffix
+	Remove-AzResourceGroup -Name $params.rgname -Force
+}

src/Synapse/Synapse.Test/ScenarioTests/WorkspaceTests.ps1

@@ -91,29 +91,6 @@ function Test-SynapseWorkspace
         }
         Assert-True {$found -eq 1} "Workspace created earlier is not found when listing all in resource group: $resourceGroupName."
 
-        # Unable to deserialize results in `Get-AzSynapseWorkspace`
-        # TODO: Update test after SDK upgrade
-
-        # List all Workspaces in subscription
-
-        # [array]$workspacesInSubscription = Get-AzSynapseWorkspace
-        # Assert-True {$workspacesInSubscription.Count -ge 1}
-        # Assert-True {$workspacesInSubscription.Count -ge $workspacesInResourceGroup.Count}
-        #
-        # $found = 0
-        # for ($i = 0; $i -lt $workspacesInSubscription.Count; $i++)
-        # {
-        #     if ($workspacesInSubscription[$i].Name -eq $workspaceName)
-        #     {
-        #         $found = 1
-        #         Assert-AreEqual $location $workspacesInSubscription[$i].Location
-        #         Assert-AreEqual "Microsoft.Synapse/workspaces" $workspacesInSubscription[$i].Type
-        #         Assert-True {$workspacesInSubscription[$i].Id -like "*$resourceGroupName*"}
-        #         break
-        #     }
-        # }
-        # Assert-True {$found -eq 1} "Workspace created earlier is not found when listing all in subscription."
-
         # Delete workspace
         Assert-True {Remove-AzSynapseWorkspace -ResourceGroupName $resourceGroupName -Name $workspaceName -PassThru -Force} "Remove Workspace failed."
 
@@ -211,12 +188,12 @@ function Test-SynapseWorkspaceSecurity
         Assert-AreEqual $auditing.StorageAccountResourceId $account.id
 
         # Enable SQL Data Security
-        $dataSecurityEnable = Enable-AzSynapseSqlAdvancedDataSecurity -WorkspaceName $workspaceName -DoNotConfigureVulnerabilityAssessment
+        $dataSecurityEnable = Enable-AzSynapseSqlAdvancedDataSecurity -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName -DoNotConfigureVulnerabilityAssessment
 
         Assert-True {$dataSecurityEnable.IsEnabled}
 
         # Get SQL Data Security Policy
-        $dataSecurityGet = Get-AzSynapseSqlAdvancedDataSecurityPolicy -WorkspaceName $workspaceName
+        $dataSecurityGet = Get-AzSynapseSqlAdvancedDataSecurityPolicy -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName
 
         Assert-True {$dataSecurityGet.IsEnabled}
 
@@ -251,7 +228,7 @@ function Test-SynapseWorkspaceSecurity
         Assert-AreEqual $threatProtectionGet.ThreatDetectionState Disabled
 
         # Disable SQL Data Security
-        $dataSecurityDisable = Disable-AzSynapseSqlAdvancedDataSecurity -WorkspaceName $workspaceName
+        $dataSecurityDisable = Disable-AzSynapseSqlAdvancedDataSecurity -ResourceGroupName $resourceGroupName -WorkspaceName $workspaceName
 
         Assert-False {$dataSecurityDisable.IsEnabled}
 
@@ -470,7 +447,7 @@ function Get-WorkspaceEncryptionTestEnvironmentParameters ($testSuffix)
 			  fileSystemName = "wscmdletfs" + $testSuffix;
 			  loginName = "testlogin";
 			  pwd = "testp@ssMakingIt1007Longer";
-              location = "eastus2euap";
+              location = "canadacentral";
               encryptionKeyIdentifier = "<your-encryptionKeyIdentifier>";
 		}
 }
@@ -539,7 +516,7 @@ function Get-WorkspaceTestEnvironmentParameters ($testSuffix)
 			  fileSystemName = "wscmdletfs" + $testSuffix;
 			  loginName = "testlogin";
 			  pwd = "testp@ssMakingIt1007Longer";
-              location = "eastus2euap";
+              location = "canadacentral";
 		}
 }