Skip to content

Added subnet property to new-AzLoadBalancerBackendAddressConfig cmdlet. Fixed piping in Set/Remove-AzLoadBalancerBackendAddressPool #15503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

irrogozh
Copy link
Member

…t. Fixed piping in Set/Remove-AzLoadBalancerBacknedAddressPool cmdlets.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…t. Fixed piping in Set/Remove-AzLoadBalancerBacknedAddressPool cmdlets.
@isra-fel isra-fel self-assigned this Jul 21, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irrogozh Why did you raise 2 PRs? #15496

@irrogozh
Copy link
Member Author

@isra-fel , I hoped that if it's possible to merge pr to main branch - to release it faster. Changes are not coupled with API version - it's mostly fixing bugs and adding missing property.

@isra-fel
Copy link
Member

@irrogozh yes it's OK to submit PR to main branch. However in that case, according to our PR strategies for network branch, instead of submitting an identical PR to network branch, the correct way is to

  1. Submit PR to main, get it merged
  2. Submit a second PR to sync main to network branch

Now that #15496 has already been merged to network-march (as I was not aware of this PR when reviewing that one), I'm planning to revert that merge and merge this PR, and you'll need to sync main to network branch after our August release. Does it sound OK to you?

@irrogozh
Copy link
Member Author

@isra-fel , sounds great! please do it:)

@isra-fel isra-fel merged commit 54b593a into Azure:main Jul 23, 2021
@isra-fel
Copy link
Member

@irrogozh so this PR was merged and network-march was reset. As plan I will notify you to sync main to network branch after next official release, which is early August.
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants