Skip to content

[RecoveryServices.Backup] Added MSI based Restore #15519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

hiaga
Copy link
Member

@hiaga hiaga commented Jul 22, 2021

Description

Added MSI based Restore

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@hiaga
Copy link
Member Author

hiaga commented Jul 27, 2021

@isra-fel : Cmdlet review done - rerecording the failed tests. We are fine if this goes with RC2 and target this for release on Aug 03

@isra-fel isra-fel changed the base branch from main to release-2021-08-03 July 27, 2021 06:14
@hiaga
Copy link
Member Author

hiaga commented Jul 27, 2021

@isra-fel : while re-recording the tests we faced a separate issue with backend, hence unable to re-record the tests on priority. I think we might need an OOB release for this important feature and can't make it for current milestone. Please let me know if any issues.

@isra-fel isra-fel removed this from the Jul 2021 (2021-08-03) milestone Jul 30, 2021
@isra-fel isra-fel changed the base branch from release-2021-08-03 to main July 30, 2021 09:09
@isra-fel
Copy link
Member

Clearing the milestone and switching base branch to main, as this PR will target OOB release in August.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please also update changelog.md


[Parameter(Mandatory = false, ParameterSetName = AzureVMManagedDiskParameterSet,
HelpMessage = ParamHelpMsgs.RestoreVM.UseMSIForRestore)]
public SwitchParameter UseMSIForRestore { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in the design review, there's no need for UseMSIForRestore, as it can be inferred by the existence of UseSystemAssignedIdentity or UserAssignedIdentityId

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the PR appropriately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@isra-fel isra-fel assigned hiaga and unassigned isra-fel Jul 30, 2021
@hiaga hiaga force-pushed the hiaga/RestoreMSI branch 2 times, most recently from 6937240 to a2b68f9 Compare August 4, 2021 01:42
re-recorded tests
@hiaga hiaga force-pushed the hiaga/RestoreMSI branch from a2b68f9 to c92214c Compare August 5, 2021 02:43
@hiaga hiaga assigned isra-fel and unassigned hiaga Aug 5, 2021
@hiaga
Copy link
Member Author

hiaga commented Aug 5, 2021

@hiaga
Copy link
Member Author

hiaga commented Aug 5, 2021

And please also update changelog.md

Done

@hiaga hiaga assigned VeryEarly and unassigned isra-fel Aug 5, 2021
@VeryEarly VeryEarly merged commit ed3d7c9 into Azure:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants