-
Notifications
You must be signed in to change notification settings - Fork 4k
[RecoveryServices.Backup] Added MSI based Restore #15519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@isra-fel : Cmdlet review done - rerecording the failed tests. We are fine if this goes with RC2 and target this for release on Aug 03 |
@isra-fel : while re-recording the tests we faced a separate issue with backend, hence unable to re-record the tests on priority. I think we might need an OOB release for this important feature and can't make it for current milestone. Please let me know if any issues. |
Clearing the milestone and switching base branch to main, as this PR will target OOB release in August. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please also update changelog.md
|
||
[Parameter(Mandatory = false, ParameterSetName = AzureVMManagedDiskParameterSet, | ||
HelpMessage = ParamHelpMsgs.RestoreVM.UseMSIForRestore)] | ||
public SwitchParameter UseMSIForRestore { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed in the design review, there's no need for UseMSIForRestore
, as it can be inferred by the existence of UseSystemAssignedIdentity
or UserAssignedIdentityId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update the PR appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
6937240
to
a2b68f9
Compare
re-recorded tests
Release Request: https://github.com/Azure/sdk-release-request/issues/1828 |
Done |
Description
Added MSI based Restore
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added