ApiManagement - new verison 2020-12-01 update #15524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource Provider changes for 2020-12-01
isra-fel
previously requested changes
Jul 23, 2021
There was a problem hiding this comment.
As the log of CI suggests, please fix 2 issues in help documents
Target : New-AzApiManagementKeyVaultObject.md
Description : Online version in the header of the file is incorrect. The
corresponding URL should be the following: https://docs.microsoft
.com/powershell/module/az.apimanagement/new-azapimanagementkeyvau
ltobject
Target : Sync-AzApiManagementKeyVaultSecret.md
Description : Online version in the header of the file is incorrect. The
corresponding URL should be the following: https://docs.microsoft
.com/powershell/module/az.apimanagement/sync-azapimanagementkeyva
ultsecret
8 tasks
isra-fel
reviewed
Jul 23, 2021
src/ApiManagement/ApiManagement/Commands/NewAzureApiManagementCustomHostnameConfiguration.cs
Outdated
Show resolved
Hide resolved
src/ApiManagement/ApiManagement/Commands/NewAzureApiManagement.cs
Outdated
Show resolved
Hide resolved
|
Besides, some scenario tests are failing |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 15524 in repo Azure/azure-powershell |
|
@isra-fel Please take a look again |
solankisamir
approved these changes
Aug 4, 2021
|
@isra-fel can you please take a look at this? |
VeryEarly
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update to latest SDK
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added