Skip to content

[Storage] Support VLW #15545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2021
Merged

[Storage] Support VLW #15545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5072c07
[Storage] Support VLW
blueww Jul 1, 2021
ff02e17
fix review comment
blueww Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Storage/Storage.Management.Test/ScenarioTests/StorageBlobTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,12 @@ public void TestStorageBlobChangeFeed()
{
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobChangeFeed");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestStorageBlobContainerVLW()
{
TestController.NewInstance.RunPsTest(_logger, "Test-StorageBlobContainerVLW");
}
}
}
81 changes: 81 additions & 0 deletions src/Storage/Storage.Management.Test/ScenarioTests/StorageBlobTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,85 @@ function Test-StorageBlobContainerLegalHold
}
}

<#
.SYNOPSIS
Test StorageAccount ObjectLevelWorm
.DESCRIPTION
SmokeTest
#>
function Test-StorageBlobContainerVLW
{
# Setup
$rgname = Get-StorageManagementTestResourceName;

try
{
# Test
$stoname = 'sto' + $rgname;
$stotype = 'Standard_GRS';
$loc = Get-ProviderLocation_Canary ResourceManagement;
$kind = 'StorageV2'
$containerName = "container"+ $rgname
$containerName2 = "container2"+ $rgname

Write-Verbose "RGName: $rgname | Loc: $loc"
New-AzResourceGroup -Name $rgname -Location $loc;

New-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype -Kind $kind
$stos = Get-AzStorageAccount -ResourceGroupName $rgname;

# enabled versioning
Update-AzStorageBlobServiceProperty -ResourceGroupName $rgname -StorageAccountName $stoname -IsVersioningEnabled $true
$property = Get-AzStorageBlobServiceProperty -ResourceGroupName $rgname -StorageAccountName $stoname
Assert-AreEqual $true $property.IsVersioningEnabled

# create container with ImmutableStorageWithVersioning
New-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -Name $containerName -EnableImmutableStorageWithVersioning
$container = Get-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -Name $containerName
Assert-AreEqual $rgname $container.ResourceGroupName
Assert-AreEqual $stoname $container.StorageAccountName
Assert-AreEqual $containerName $container.Name
Assert-AreEqual $false $container.HasLegalHold
Assert-AreEqual $false $container.HasImmutabilityPolicy
Assert-AreEqual $true $container.ImmutableStorageWithVersioning.Enabled

# migrate container to enable VLW
New-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -Name $containerName2
$container = Get-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -Name $containerName2
Assert-AreEqual $rgname $container.ResourceGroupName
Assert-AreEqual $stoname $container.StorageAccountName
Assert-AreEqual $containerName2 $container.Name
Assert-AreEqual $false $container.HasLegalHold
Assert-AreEqual $false $container.HasImmutabilityPolicy
Assert-AreNotEqual $true $container.ImmutableStorageWithVersioning.Enabled

$immutabilityPeriod =1
Set-AzRmStorageContainerImmutabilityPolicy -ResourceGroupName $rgname -StorageAccountName $stoname -ContainerName $containerName2 -ImmutabilityPeriod $immutabilityPeriod
$policy = Get-AzRmStorageContainerImmutabilityPolicy -ResourceGroupName $rgname -StorageAccountName $stoname -ContainerName $containerName2
Assert-AreEqual $immutabilityPeriod $policy.ImmutabilityPeriodSinceCreationInDays
Assert-AreEqual Unlocked $policy.State

$t = Invoke-AzRmStorageContainerImmutableStorageWithVersioningMigration -ResourceGroupName $rgname -StorageAccountName $stoname -Name $containerName2 -asjob
$t | Wait-Job
$container = Get-AzRmStorageContainer -ResourceGroupName $rgname -StorageAccountName $stoname -Name $containerName2
Assert-AreEqual $true $container.ImmutableStorageWithVersioning.Enabled

# remove the containers
Remove-AzRmStorageContainer -Force -StorageAccount $stos -Name $containerName
Remove-AzRmStorageContainer -Force -StorageAccount $stos -Name $containerName2
$containers = Get-AzRmStorageContainer -StorageAccount $stos
Assert-AreEqual 0 $containers.Count

Remove-AzStorageAccount -Force -ResourceGroupName $rgname -Name $stoname;
}
finally
{
# Cleanup
Clean-ResourceGroup $rgname
}
}



function Test-StorageBlobContainerImmutabilityPolicy
{
Expand Down Expand Up @@ -669,6 +748,8 @@ function Test-StorageBlobORS
Assert-AreEqual dest $srcPolicy.Rules[1].DestinationContainer
Assert-AreEqual 3 $srcPolicy.Rules[1].Filters.PrefixMatch.Count
Assert-AreEqual $minCreationTime ($srcPolicy.Rules[1].Filters.MinCreationTime.ToUniversalTime().ToString("s")+"Z")
$destPolicy | Remove-AzStorageObjectReplicationPolicy
$srcPolicy | Remove-AzStorageObjectReplicationPolicy

# disable AllowCrossTenantReplication
$sto1 = Set-AzStorageAccount -ResourceGroupName $rgname -StorageAccountName $stoname1 -AllowCrossTenantReplication $false -EnableHttpsTrafficOnly $true
Expand Down
53 changes: 18 additions & 35 deletions src/Storage/Storage.Management.Test/ScenarioTests/StorageDataPlaneTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,41 +336,24 @@ function Test-Blob
Disable-AzStorageContainerDeleteRetentionPolicy -ResourceGroupName $ResourceGroupName -Name $StorageAccountName
Remove-AzStorageContainer -Name $containerNamesoftdelete -Context $storageContext -Force

# container softdelete test
## Enabled container softdelete,then create and delete a container
Enable-AzStorageContainerDeleteRetentionPolicy -ResourceGroupName $ResourceGroupName -Name $StorageAccountName -RetentionDays 3
$containerNamesoftdelete = "softdeletecontainer"
$newcontainerName = "newcontainer"
New-AzStorageContainer -Name $containerNamesoftdelete -Context $storageContext
Remove-AzStorageContainer -Name $containerNamesoftdelete -Context $storageContext -Force
## Get container without -IncludeDeleted, won't list out deleted containers
$deletedcontainer = Get-AzStorageContainer -Context $storageContext | ?{$_.IsDeleted}
Assert-AreEqual 0 $deletedcontainer.Count
## Get container with -IncludeDeleted, will list out deleted containers
$deletedcontainer = Get-AzStorageContainer -Context $storageContext -IncludeDeleted | ?{$_.IsDeleted}
Assert-AreEqual 1 $deletedcontainer.Count
Assert-AreEqual $true $deletedcontainer.IsDeleted
Assert-NotNull $deletedcontainer.VersionId
## restore container with pipeline, to same container name
sleep 60 # need wait for some time, or restore will fail with 409 (The specified container is being deleted.)
$deletedcontainer | Restore-AzStorageContainer
$container = Get-AzStorageContainer -Name $containerNamesoftdelete -Context $storageContext
Assert-AreEqual 1 $container.Count
Assert-Null $container.IsDeleted
Assert-Null $container.VersionId
## restore container with parameter, to a new container name
Remove-AzStorageContainer -Name $containerNamesoftdelete -Context $storageContext -Force
$deletedcontainer = Get-AzStorageContainer -Context $storageContext -IncludeDeleted | ?{$_.IsDeleted}
Assert-AreEqual 1 $deletedcontainer.Count
sleep 60 # need wait for some time, or restore will fail with 409 (The specified container is being deleted.)
Restore-AzStorageContainer -Name $deletedcontainer[0].Name -VersionId $deletedcontainer[0].VersionId -DestinationContainerName $newcontainerName -Context $storageContext
$container = Get-AzStorageContainer -Name $newcontainerName -Context $storageContext
Assert-AreEqual 1 $container.Count
Assert-AreEqual $newcontainerName $container.Name
Assert-Null $container.IsDeleted
Assert-Null $container.VersionId
Disable-AzStorageContainerDeleteRetentionPolicy -ResourceGroupName $ResourceGroupName -Name $StorageAccountName
Remove-AzStorageContainer -Name $newcontainerName -Context $storageContext -Force
# VLW
## enabled versioning
Update-AzStorageBlobServiceProperty -ResourceGroupName $ResourceGroupName -Name $StorageAccountName -IsVersioningEnabled $true
$containerNamevlw = "vlwcontainer"
# create container with ImmutableStorageWithVersioning
New-AzRmStorageContainer -ResourceGroupName $ResourceGroupName -Name $StorageAccountName -Name $containerNamevlw -EnableImmutableStorageWithVersioning
# upload a blob
Set-AzStorageBlobContent -File $localSrcFile -Container $containerNamevlw -Blob $objectName -Force -Context $storageContext
# manage ImmutabilityPolicy
$policy = Set-AzStorageBlobImmutabilityPolicy -Container $containerNamevlw -Blob $objectName -ExpiriesOn (Get-Date).AddDays(1) -PolicyMode Unlocked -Context $storageContext
$blob = Get-AzStorageBlob -Container $containerNamevlw -Blob $objectName -Context $storageContext
Remove-AzStorageBlobImmutabilityPolicy -Container $containerNamevlw -Blob $objectName -Context $storageContext
$blob = Get-AzStorageBlob -Container $containerNamevlw -Blob $objectName -Context $storageContext
# manage legalhold
Set-AzStorageBlobLegalHold -Container $containerNamevlw -Blob $objectName -Context $storageContext -EnableLegalHold
$blob = Get-AzStorageBlob -Container $containerNamevlw -Blob $objectName -Context $storageContext
Set-AzStorageBlobLegalHold -Container $containerNamevlw -Blob $objectName -Context $storageContext -DisableLegalHold
$blob = Get-AzStorageBlob -Container $containerNamevlw -Blob $objectName -Context $storageContext

# Clean Storage Account
Remove-AzStorageContainer -Name $containerName -Force -Context $storageContext
Expand Down
Loading