Skip to content

[Az.Migrate] Tagging bug fix #15572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 28, 2021
Merged

[Az.Migrate] Tagging bug fix #15572

Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a1a0073
move to 2021 swagger
prsadhu-ms-idc Jun 8, 2021
27e93b9
Changing default recovery for CBT
singhabh27 Jun 14, 2021
2f64d35
Azure Migrate Initialize Replication Infrastructure UserObject cmdlet…
singhabh27 Jun 15, 2021
6be02dd
Included SQL License Type and Resource Tagging Feature
singhabh27 Jun 30, 2021
024e98a
Simplified Set-AzMigrateServerReplication.ps1 to avoid repetition of …
singhabh27 Jul 1, 2021
a8550b1
Few fixes in Set-AzMigrateServerReplication.ps1
singhabh27 Jul 1, 2021
3921f9a
Changes in New-AzMigrateServerReplication.ps1
singhabh27 Jul 2, 2021
442dbe8
Changed Variable Name
singhabh27 Jul 5, 2021
2889ced
Removed SeedDiskTag
singhabh27 Jul 5, 2021
72e4d6a
Updated SQL Server License Type Summary and fixed tag Count issue.
singhabh27 Jul 6, 2021
78c82f3
Merge pull request #49 from prsadhu-ms-idc/sqllicensetypeandtaggingch…
singhabh27 Jul 12, 2021
0369735
Adding CRN feature.
singhabh27 Jul 15, 2021
8ab01ad
Error msg change
singhabh27 Jul 22, 2021
5ca6b80
Recorded tests
singhabh27 Jul 22, 2021
5df3352
Tagging change as per design review
singhabh27 Jul 22, 2021
f624cd2
Merge pull request #50 from prsadhu-ms-idc/addingcrnfeature
singhabh27 Jul 22, 2021
2d5592f
Merge pull request #51 from prsadhu-ms-idc/cbtrecordtest
singhabh27 Jul 22, 2021
2dff53d
Adding error msg when tag key is passed as empty string
singhabh27 Jul 22, 2021
a50554f
Fix in Nickname spelling
singhabh27 Jul 23, 2021
4c03fc9
add breaking change and signature suppression
isra-fel Jul 26, 2021
1bb48c1
Merge branch 'generation' into 2106SRS
isra-fel Jul 26, 2021
fac9a24
Test fixed
singhabh27 Jul 26, 2021
7875ce3
Merge branch '2106SRS' of https://github.com/prsadhu-ms-idc/azure-pow…
singhabh27 Jul 26, 2021
4f00b1b
Bug Fix
singhabh27 Jul 28, 2021
102db93
Merge pull request #52 from Azure/generation
prsadhu-ms-idc Jul 28, 2021
af69ba7
Merge branch '2106SRS' into generation
prsadhu-ms-idc Jul 28, 2021
5dd385a
BUG fix
singhabh27 Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Migrate/custom/Set-AzMigrateServerReplication.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ function Set-AzMigrateServerReplication {
$UserProvidedTag += @{$operation = $UpdateNicTag}
}
else {
$ProviderSpecificDetails.TargetVmTag = $ReplicationMigrationItem.ProviderSpecificDetail.TargetVmTag
$ProviderSpecificDetails.TargetNicTag = $ReplicationMigrationItem.ProviderSpecificDetail.TargetNicTag
}

if ($HasUpdateDiskTag -And $HasUpdateDiskTagOperation -And $UpdateDiskTag)
Expand All @@ -347,7 +347,7 @@ function Set-AzMigrateServerReplication {
$UserProvidedTag += @{$operation = $UpdateDiskTag}
}
else {
$ProviderSpecificDetails.TargetVmTag = $ReplicationMigrationItem.ProviderSpecificDetail.TargetVmTag
$ProviderSpecificDetails.TargetDiskTag = $ReplicationMigrationItem.ProviderSpecificDetail.TargetDiskTag
}

foreach($tag in $UserProvidedTag.Keys)
Expand Down Expand Up @@ -623,6 +623,7 @@ function Set-AzMigrateServerReplication {
$updateNic.NicId = $storedNic.NicId
$updateNic.TargetStaticIPAddress = $storedNic.TargetIPAddress
$updateNic.TargetSubnetName = $storedNic.TargetSubnetName
$updateNic.TargetNicName = $storedNic.TargetNicName

$matchingUserInputNic = $null
if ($HasNicToUpdate) {
Expand Down