Skip to content

Add note to Add-AzVMSecret.md (Ready to Merge) #15579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Add note to Add-AzVMSecret.md (Ready to Merge) #15579

merged 4 commits into from
Jul 30, 2021

Conversation

mimckitt
Copy link
Contributor

@mimckitt mimckitt commented Jul 29, 2021

Description

Add note to Add-AzVMSecret.md and remove the example I added before.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@mimckitt
Copy link
Contributor Author

@smotwani how do you feel about this format? Essentially keeping the information the same but adding a note that points users to the key vault extension where they can find examples of how to use it. That way we are not clogging up the command page with a different command but instead use this page to point users where we want them to be.

@smotwani
Copy link

@smotwani how do you feel about this format? Essentially keeping the information the same but adding a note that points users to the key vault extension where they can find examples of how to use it. That way we are not clogging up the command page with a different command but instead use this page to point users where we want them to be.

@mimckitt the format looks good to me.

@mimckitt mimckitt changed the title Update Add-AzVMSecret.md Add note to Add-AzVMSecret.md and remove the example I added before. Jul 29, 2021
@mimckitt mimckitt changed the title Add note to Add-AzVMSecret.md and remove the example I added before. Add note to Add-AzVMSecret.md (Ready to Merge) Jul 29, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@isra-fel isra-fel merged commit d4187b5 into Azure:main Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants