set default value for auto pause and auto scale settings of New-AzSynapseSparkPool cmdlet #15600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idear1203
reviewed
Aug 3, 2021
| @@ -178,13 +178,13 @@ public override void ExecuteCmdlet() | |||
| NodeCount = this.enableAutoScale ? (int?) null : this.NodeCount, | |||
| NodeSizeFamily = NodeSizeFamily.MemoryOptimized, | |||
| NodeSize = NodeSize, | |||
| AutoScale = !this.enableAutoScale ? null : new AutoScaleProperties | |||
| AutoScale = !this.enableAutoScale ? new AutoScaleProperties { Enabled = this.enableAutoScale } : new AutoScaleProperties | |||
idear1203
reviewed
Aug 3, 2021
| { | ||
| Enabled = this.enableAutoScale, | ||
| MinNodeCount = AutoScaleMinNodeCount, | ||
| MaxNodeCount = AutoScaleMaxNodeCount | ||
| }, | ||
| AutoPause = !EnableAutoPause ? null : new AutoPauseProperties | ||
| AutoPause = !EnableAutoPause ? new AutoPauseProperties { Enabled = EnableAutoPause.IsPresent } : new AutoPauseProperties |
|
please add changelog |
yanjungao718
force-pushed
the
synapse-spark-pool
branch
2 times, most recently
from
f6562da to
c1c24d7
Compare
yanjungao718
force-pushed
the
synapse-spark-pool
branch
from
c1c24d7 to
cd1a60a
Compare
idear1203
approved these changes
Aug 4, 2021
|
hi @idear1203 @VeryEarly , merging is blocked due to unauthorized, could you please help to do this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set default value for auto pause and auto scale settings of New-AzSynapseSparkPool cmdlet
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added