Skip to content

[CosmosDB] Changing the warning message for AnalyticalStorageSchemaType #15723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2021

Conversation

toswedlu
Copy link
Contributor

Changing the warning message for AnalyticalStorageSchemaType to only display when a value has been explicitly provided.

Description

Checklist

  • [x ] I have read the Submitting Changes section of CONTRIBUTING.md
  • [x ] The title of the PR is clear and informative
  • x[ ] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [x ] The PR does not introduce breaking changes
  • [x ] If applicable, the changes made in the PR have proper test coverage
  • x[ ] For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…display when a value has been explicitly provided
@ghost ghost added the customer-reported label Aug 21, 2021
@ghost
Copy link

ghost commented Aug 21, 2021

Thank you for your contribution toswedlu! We will review the pull request and get back to you soon.

@VeryEarly VeryEarly self-assigned this Aug 24, 2021
@VeryEarly
Copy link
Collaborator

Hi @toswedlu , please update changelog as well

@toswedlu
Copy link
Contributor Author

Hi Yabo,

Considering I'm only changing when a warning message appears, should I bother updating the changelog?

Thanks,
Tom

@ghost
Copy link

ghost commented Aug 27, 2021

CLA assistant check
All CLA requirements met.

VeryEarly
VeryEarly previously approved these changes Aug 27, 2021
@VeryEarly
Copy link
Collaborator

hi @toswedlu ,

Please sign license/cla, otherwise PR cannot be merged.

mkmibrahim
mkmibrahim previously approved these changes Oct 1, 2021
@isra-fel
Copy link
Member

isra-fel commented Nov 1, 2021

Let me rebase the commit tomorrow to avoid issues in change log

@isra-fel isra-fel dismissed stale reviews from mkmibrahim and VeryEarly via cb22a27 November 10, 2021 07:51
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution :)

@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit 4cd6b32 into Azure:main Nov 10, 2021
@toswedlu
Copy link
Contributor Author

toswedlu commented Dec 9, 2021

Hi @isra-fel, I see that this has been merged, but is not assigned to any milestone. Does this need to be assigned to a milestone to be released?

Thanks!,
Tom

@isra-fel
Copy link
Member

Hey Tom @toswedlu judging from the date this was merged, it should have already been in the latest release (2021-12-07). If not please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants