-
Notifications
You must be signed in to change notification settings - Fork 4k
[CosmosDB] Changing the warning message for AnalyticalStorageSchemaType #15723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…display when a value has been explicitly provided
Thank you for your contribution toswedlu! We will review the pull request and get back to you soon. |
Hi @toswedlu , please update changelog as well |
Hi Yabo, Considering I'm only changing when a warning message appears, should I bother updating the changelog? Thanks, |
hi @toswedlu , Please sign license/cla, otherwise PR cannot be merged. |
Let me rebase the commit tomorrow to avoid issues in change log |
… toswedlu-schema-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution :)
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @isra-fel, I see that this has been merged, but is not assigned to any milestone. Does this need to be assigned to a milestone to be released? Thanks!, |
Hey Tom @toswedlu judging from the date this was merged, it should have already been in the latest release (2021-12-07). If not please let me know. |
Changing the warning message for AnalyticalStorageSchemaType to only display when a value has been explicitly provided.
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added