Update Compute library to Swagger-generated one #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…swagger Conflicts: src/ResourceManager/Compute/Commands.Compute.Test/packages.config src/ResourceManager/Compute/Commands.Compute/RemoteDesktop/GetAzureRemoteDesktopFileCommand.cs src/ResourceManager/Compute/Commands.Compute/packages.config
…swagger Conflicts: src/ResourceManager/Compute/Commands.Compute.Test/packages.config src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj src/ResourceManager/Compute/Commands.Compute/packages.config
| } | ||
|
|
||
| List<PSVirtualMachineSize> psResultList = new List<PSVirtualMachineSize>(); | ||
| foreach (var item in result.VirtualMachineSizes) | ||
| foreach (var item in result.Body) |
There was a problem hiding this comment.
The converted field's name Body is weird... Is it possible to define VirtualMachineSizes?
There was a problem hiding this comment.
You're getting Body because you're using ListWithHttpMessagesAsync(). If you were to use just List() you would get a collection right away.
There was a problem hiding this comment.
OK, but List doesn't contain the operation info that we want.
Will it be feasible to return a named collection in the async method? [feature request]
|
LGTM, in case the |
stankovski
added a commit
that referenced
this pull request
Jan 6, 2016
Update Compute library to Swagger-generated one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.