Skip to content

[MaintenanceService] Added Support for InGuestPatch maintenance scope. #15827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KalpeshChavan12
Copy link
Contributor

Description

Added Paramter to cmdlet to create InGuestPatch maintenance config.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@KalpeshChavan12
Copy link
Contributor Author

.Net SDK not yet published

Azure/azure-sdk-for-net#23812

Test recorded using local .net sdk build

@KalpeshChavan12 KalpeshChavan12 force-pushed the release-Maintenance-2021-09-04-preview branch from 064888b to bac5fb5 Compare September 24, 2021 17:38
@KalpeshChavan12 KalpeshChavan12 marked this pull request as ready for review September 24, 2021 17:40
@dingmeng-xue
Copy link
Member

According to the syntax of Update-AzMaintenanceConfiguration, you need to add new parameters to PSMaintenanceConfiguration. Otherwise, user cannot update this resource.

@dingmeng-xue dingmeng-xue added needs-author-feedback More information is needed from author to address the issue. needs-revision and removed needs-author-feedback More information is needed from author to address the issue. labels Sep 27, 2021
@KalpeshChavan12
Copy link
Contributor Author

According to the syntax of Update-AzMaintenanceConfiguration, you need to add new parameters to PSMaintenanceConfiguration. Otherwise, user cannot update this resource.

Update accept configuration object as parameter, Use can get object using Get-AzMaintenanceConfiguration or New-AzMaintennaceConfiguration and mofify object and pass to Update-AzMaintenanceConfiguration.

We need to update object return to user as Get and New cmdlets

Thanks for review.

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@KalpeshChavan12 KalpeshChavan12 force-pushed the release-Maintenance-2021-09-04-preview branch from bac5fb5 to e61079a Compare September 27, 2021 22:05
@KalpeshChavan12
Copy link
Contributor Author

According to the syntax of Update-AzMaintenanceConfiguration, you need to add new parameters to PSMaintenanceConfiguration. Otherwise, user cannot update this resource.

Fixed in latest revision.

Please review. PR

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@KalpeshChavan12
Copy link
Contributor Author

@wyunchi-ms
Can you please merge change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants