Skip to content

Sign AuthenticationAssemblyLoadContext.dll in daily build #15934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Sep 23, 2021

Sign AuthenticationAssemblyLoadContext.dll in daily build
Otherwise on windows powershell this assembly cannot be loaded.

The azure-powershell - sign pipeline is also updated.

Todo:

  • make sure every assembly in the final package is signed

@isra-fel isra-fel changed the title Update daily-build.yml for Azure Pipelines Sign AuthenticationAssemblyLoadContext.dll in daily build Sep 23, 2021
BethanyZhou
BethanyZhou previously approved these changes Sep 23, 2021
@@ -96,6 +96,7 @@ jobs:
Release/**/Az.*.private.dll
Release/**/Microsoft.Azure.PowerShell.Authentication.dll
Release/**/Microsoft.Azure.PowerShell.Authentication.ResourceManager.dll
Release/**/Microsoft.Azure.PowerShell.AuthenticationAssemblyLoadContext.dll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you added this assembly into the task in our regular sign pipeline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@isra-fel isra-fel marked this pull request as draft September 23, 2021 07:26
@isra-fel isra-fel marked this pull request as ready for review September 23, 2021 08:03
@isra-fel isra-fel self-assigned this Sep 23, 2021
@isra-fel
Copy link
Member Author

@isra-fel isra-fel merged commit 10cb220 into main Sep 23, 2021
@isra-fel isra-fel deleted the yeming/sign-alc branch September 23, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants