Improve diagnostics extension command #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ServiceName a mandatory parameter. 2) Add the missing -Role parameter
…agnosticsExtension should remove the extension for all roles.
…t diagnostics extension
…gx file as config file
…optional parameters. And make StorageContext optional parameter as well.
…elated parameters as optional parameters
…osticsExtension can take an array of configuration and update multi roles with different configurations
|
I don't believe I'm the bfung you're looking for, there are some simple fixes I could suggest, but perhaps they've been caught by the build? ;) |
|
@bfung, didn't noticed the alias points to you by mistake. Looks like the failure is because one of the record file is not "Copy Always". |
… at github build step.
| int wadCfgBeginIndex = config.IndexOf("<WadCfg>"); | ||
| if (wadCfgBeginIndex == -1) | ||
| { | ||
| throw new ArgumentException("Cannot find the WadCfg element in the config."); |
There was a problem hiding this comment.
Please add all text strings for the exceptions to the resources and reference it from there.
There was a problem hiding this comment.
Please add all text strings for the exceptions to the resources and reference it from there.
Thanks! Done.
hovsepm
pushed a commit
that referenced
this pull request
Jan 14, 2016
Improve diagnostics extension command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change has gone through internal code review. Reviewer: @bfung, @rapandit
And the changes including: