Skip to content

[Synapse] Spark Configuration cmdlets #16156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2021
Merged

[Synapse] Spark Configuration cmdlets #16156

merged 2 commits into from
Nov 11, 2021

Conversation

yanjungao718
Copy link
Contributor

@yanjungao718 yanjungao718 commented Oct 21, 2021 •
edited
Loading

Description

Add Synapse Spark Configuration related cmdlets:
New-AzSynapseSparkConfiguration
Get-AzSynapseSparkConfiguration
Export-AzSynapseSparkConfiguration
Remove-AzSynapseSparkConfiguration

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@BethanyZhou
Copy link
Contributor

@yanjungao718 , please fix signature issue first:

"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Az.Synapse","Microsoft.Azure.Commands.Synapse.ExportAzureSynapseSparkConfiguration","Export-AzSynapseSparkConfiguration","1","8100","Export-AzSynapseSparkConfiguration Does not support ShouldProcess but the cmdlet verb Export indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

@yanjungao718
Copy link
Contributor Author

@yanjungao718 , please fix signature issue first:

"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Az.Synapse","Microsoft.Azure.Commands.Synapse.ExportAzureSynapseSparkConfiguration","Export-AzSynapseSparkConfiguration","1","8100","Export-AzSynapseSparkConfiguration Does not support ShouldProcess but the cmdlet verb Export indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

@BethanyZhou Beisi, already updated to signature issue file.

@yanjungao718
Copy link
Contributor Author

spark config backend have not finished deployment, make it draft to wait for finishing.

@yanjungao718 yanjungao718 marked this pull request as draft October 22, 2021 08:17
@yanjungao718 yanjungao718 marked this pull request as ready for review November 10, 2021 07:47
isra-fel
isra-fel requested changes Nov 10, 2021
View reviewed changes
@yanjungao718
[Synapse] Spark Configuration cmdlets
e47633d 
modify signature issue info

modify SignatureIssues.csv

modify help doc

add change log for spark configuration

add help doc for spark configuration

remove unnecessary parameter set

add/remove blank lines

revert local test endpoint

add export command, made some ohter changes

add export command & refine code

revert PSActivityRun

edited PSActivityRun by mistake, revert it

use lowercase for parameter initials

refine code for spark configuration

spark configuration related command
@yanjungao718
remove unnecessary release note
9885d32
isra-fel
isra-fel approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit 26d8c9a into Azure:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@BethanyZhou BethanyZhou Awaiting requested review from BethanyZhou

@idear1203 idear1203 Awaiting requested review from idear1203

@wonner wonner Awaiting requested review from wonner

@v-hozhao v-hozhao Awaiting requested review from v-hozhao

Assignees

@isra-fel isra-fel

@yanjungao718 yanjungao718

Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanjungao718 @BethanyZhou @isra-fel