Skip to content

[Resources] Add Publish-AzBicepModule for publishing Bicep files #16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 11, 2021

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Oct 21, 2021

Description

In the recent release of Bicep CLI, we added a new command bicep publish for publish a module to a container registry (see https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-cli#publish). The PR adds a new cmdlet Publish-AzBicepModule which allows Bicep and Azure PowerShell users to publish Bicep modules via PowerShell without the need to invoke the bicep publish command.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue
Copy link
Member

Please provide the detail description about this cmdlet.

@dcaro FYI.

@shenglol
Copy link
Contributor Author

Please provide the detail description about this cmdlet.

@dcaro FYI.

Hi @dingmeng-xue, I've updated the description. Could you take another look?

dingmeng-xue
dingmeng-xue previously approved these changes Oct 28, 2021
@dingmeng-xue
Copy link
Member

Approve the PR. Merge it after release branch is merged back.

Co-authored-by: Beisi Zhou <[email protected]>
@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel assigned shenglol and unassigned dingmeng-xue Nov 8, 2021
@shenglol shenglol requested a review from isra-fel November 8, 2021 17:24
@shenglol
Copy link
Contributor Author

shenglol commented Nov 9, 2021

@isra-fel I've addressed the comments. Mind taking another look?

@isra-fel
Copy link
Member

isra-fel commented Nov 9, 2021

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

isra-fel
isra-fel previously approved these changes Nov 9, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

```

### -PassThru
{{ Fill PassThru Description }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this placeholder by regenerating the help file.

isra-fel
isra-fel previously approved these changes Nov 9, 2021
@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

isra-fel
isra-fel previously approved these changes Nov 10, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel dismissed BethanyZhou’s stale review November 11, 2021 01:10

comments addressed

@isra-fel isra-fel merged commit ec24657 into Azure:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants