Use Use Graph v2 NuGet package in Key Vault PowerShell instead of ref… #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pomortaz, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
please upgrade GRaph RBAC SDK package to 1.8.0 |
|
please add on-demand job execution link to PR comments. |
| @@ -799,6 +799,9 @@ | |||
| <Component Id="cmp5835D87A5A94F44EAAAE61BCA33C1D80" Guid="*"> | |||
| <File Id="filEC64A002E6CBA598F7148F816DB05F11" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.DataLakeAnalytics\Microsoft.Azure.Commands.DataLakeAnalytics.dll" /> | |||
| </Component> | |||
| <Component Id="cmp96C621A371FF4A410548AAB167869D94" Guid="*"> | |||
| <File Id="filC7912B6B895CF7DF00A7C7F821AE40BF" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.DataLakeAnalytics\Microsoft.Azure.Commands.DataLakeAnalytics.dll-help.xml" /> | |||
There was a problem hiding this comment.
you should not have DataLake dependency changes. please run git clean -dfx and then run BuildInstaller.ps1 from tools folder again.
…erencing PowerShell AD code which is broken in Fairfax
Graph calls (*AzureRmAD* cmdlets) in Fairfax are broken because of
the access token with wrong audience that is used for authentication
with Graph service. Key Vault has a dependency to these cmdlets and
therefore broken if FF. This change is to remove the dependency to
PowerShell implementation of Graph authentication and AzureRmAD
internal code and directly reference the new version of the Graph SDK
v2.
stankovski
added a commit
that referenced
this pull request
Jan 11, 2016
Use Use Graph v2 NuGet package in Key Vault PowerShell instead of ref…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erencing PowerShell AD code which is broken in Fairfax