Clu #1620
Clu #1620
Conversation
Clu branch update
Clu branch update
… overridden object.ToString(). For example, the string type has overridden ToString so it is included in the printed fields.
|
Hi @BurtBiel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
…o "ls" and a condensing of the az params. Also updated the tests to use the new az params as well.
|
@azuresdkci retest this please |
| @@ -3,15 +3,15 @@ set -e | |||
| printf "\n=== Managing Virtual Machine Creation in Azure Compute ===\n" | |||
|
|
|||
| printf "\n1. Creating a new resource group: %s and location: %s.\n" "$groupName" "$location" | |||
| az group create -n "$groupName" --location "$location" | |||
| az resourcemanager group create -n "$groupName" --location "$location" | |||
There was a problem hiding this comment.
This is the most used cmdlet in the entire set opf cmdlets - you have to create a resource group to do anything else. Do we really want the cmdlet name to be so wordy?
There was a problem hiding this comment.
Joe/Jason would like to keep the resourcemanager term. Is it possible to create an alias for the term?
There was a problem hiding this comment.
@BurtBiel The decision we came to this morning was to use azure resourceGroup [verb]
|
@BurtBiel There are merge conflicts, please update, and please ensure that scenario tests pass, as it looks like at least some shell example scripts were not updated. |
|
I'm getting setup to check the scenario tests now, I'll let you know the results |
| @@ -26,6 +26,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation | |||
| /// Gets the deployment operation. | |||
| /// </summary> | |||
| [Cmdlet(VerbsCommon.Get, "AzureRmResourceGroupDeploymentOperation"), OutputType(typeof(PSResourceObject))] | |||
| [CliCommandAlias("resourcemanager;group;deployment;operation;ls")] | |||
There was a problem hiding this comment.
Why don't we use "space" instead of semicolon for noun separator
|
about half the tests passed, the failures appear to be for reasons other than the rename. . 02-Resource.sh . 04-RoleAssignments.sh . 05-RoleDefinitions.sh . 01-Storage-Accounts.sh . 01-VirtualHardDisks.sh . 01-AppServicePlan.sh - 03-WebApp
|
This PR now contains 2 changes from today, 1) updating the default format to not include object-based ToStrings, and 2) the rename of the cmdlet cli usage params