Skip to content

Updated nuget package for officially publushed #16274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2021
Merged

Updated nuget package for officially publushed #16274

merged 1 commit into from
Nov 2, 2021

Conversation

MikhailTryakhov
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov commented Oct 29, 2021 •
edited
Loading

Description

Replaced locally built SDKs with officially published one

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@MikhailTryakhov
Copy link
Contributor Author

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Commenter does not have sufficient privileges for PR 16274 in repo Azure/azure-powershell

@MikhailTryakhov
Copy link
Contributor Author

Guys @bilaakpan-ms, @grizzlytheodore, @haagha, @Sandido, some "wonderful" things happened in repo for last month. I'll have to work in it from my forked repo by some reason :(
But also can't even rerun failed jobs???? Can someone please help me to figure out with these timeout exception and give me at least some permissions to do at least trivial things? I'm entire Azure Networking release manager, maybe we can not to restrict me so much?

@isra-fel
Copy link
Member

isra-fel commented Nov 1, 2021

Hi @MikhailTryakhov it was due to our recent reorgnization of repo authorization.
I've sent you an invitation to the right team. Please check your email. Thanks

@isra-fel
Copy link
Member

isra-fel commented Nov 1, 2021

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel self-assigned this Nov 1, 2021
@MikhailTryakhov
Copy link
Contributor Author

Thx, it passed now, @isra-fel can you please review it and approve?

@MikhailTryakhov
Copy link
Contributor Author

BTW, I didn't receive any email :(

isra-fel
isra-fel approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@MikhailTryakhov I just checked your name is already on the members list so I guess it doesn't need a confirmation ;)

@isra-fel isra-fel merged commit 261002d into Azure:network-may-21 Nov 2, 2021
isra-fel added a commit that referenced this pull request Nov 9, 2021
@MikhailTryakhov @shengliumsft
@tejasshah7 @dtuCloud @BethanyZhou @isra-fel
Azure Network May release (#16327)
40b58bc 
* [Network] Add Optional Parameter IsSecuritySite to New-AzVpnSite Cmdlet (#15912)

* add isSecuritySite to vpnSite

* change to switchParameter

* add record test

* add test result

* add test with vpnsitelink

* add test with vpnsitelink

* add test with vpnsitelink

* add tests for backward compatibility

* changeLog updated

* changeLog updated

* add help files

* Support for new WAF Exclusion Match Variables (#16126)

* Support for WAF Per Rule Exclusions (#16127)

* Support for WAF Per Rule Exclusions

* Including SDK

* Add Encryption Parameters in VNet  (#16129)

* draft: local debug able to send command

* fix the console output

* add tests

* change help md

* record and change log

* add assertion on peering

* try adding json file to csproj

* try wait for the job to be done

* change to liveonly

* address comment: update help message

Co-authored-by: Beisi Zhou <[email protected]>

* Added new nuget package (#16274)

* Update ChangeLog.md

* Removed conflict mark

* Moved bastion changes to the correct one

* fixed incorrect merging section

Co-authored-by: Sheng Liu <[email protected]>
Co-authored-by: tejasshah7 <[email protected]>
Co-authored-by: dtuCloud <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@bilaakpan-ms bilaakpan-ms Awaiting requested review from bilaakpan-ms

@grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore

@haagha haagha Awaiting requested review from haagha

@Sandido Sandido Awaiting requested review from Sandido

Assignees

@isra-fel isra-fel

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikhailTryakhov @isra-fel