Skip to content

Update New-AzAutomationSourceControl.md #16366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

isjwuk
Copy link
Contributor

@isjwuk isjwuk commented Nov 9, 2021

Depersonalised (replaced "My Azure Automation account" with "an Azure Automation account".
Would also like to query the $token values in lines 32, 54, 75 - are these meant to be included or are they the authors personal access tokens?

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

Depersonalised (replaced "My Azure Automation account" with "an Azure Automation account". 
Would also like to query the $token values in lines 32, 54, 75 - are these meant to be included or are they the authors personal access tokens?
@ghost ghost added the customer-reported label Nov 9, 2021
@ghost
Copy link

ghost commented Nov 9, 2021

Thank you for your contribution isjwuk! We will review the pull request and get back to you soon.

@isra-fel
Copy link
Member

isra-fel commented Nov 9, 2021

Hey Chris, thanks for the contribution!
As for the access token, I believe they are not real ones, as they are not in the form of a json web token.

@isra-fel
Copy link
Member

isra-fel commented Nov 9, 2021

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel self-assigned this Nov 9, 2021
@isra-fel isra-fel merged commit eed22b0 into Azure:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants