Skip to content

Add basic dockerfile #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Add basic dockerfile #1666

merged 1 commit into from
Jan 20, 2016

Conversation

colemickens
Copy link

This will at least let users get up and running without needing to worry about dependencies, or let them run on non 14.04 systems.

It'd be better if in the future the build output a versioned docker container - it might look very similar to this Dockerfile but the tarball would be ADDed instead of how this installs wget and pulls down whatever happens to be the latest version.

If there are build instructions for Linux I can take a crack at it.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @colemickens, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (colemick). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Jan 15, 2016

@azuresdkci add to whitelist

@colemickens
Copy link
Author

How do I prompt the bot to rebuild this? This shouldn't impact any existing tests.


# all in one RUN to produce less, smaller layers
RUN bash -c "\
sudo apt-get -qqy update; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curios why don't you just RUN apt-get -qqy update && apt-get -qqy upgrade && etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking about the use of ; vs && ? You're right, it would be best to use &&. I'll update momentarily.

@markcowl
Copy link
Member

@colemickens Thanks for the contribution! Please respond to feedback

@colemickens
Copy link
Author

Pushed a new commit based on one of the pieces of feedback. Just rebuilt the container to check -- az is available and executable as soon as the container starts.

stankovski added a commit that referenced this pull request Jan 20, 2016
@stankovski stankovski merged commit e2db619 into Azure:clu Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants