-
Notifications
You must be signed in to change notification settings - Fork 4k
[Do not Mege] Updated Set-AzureRmVMChefExtension cmd #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @NimishaS, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
@NimishaS Please remove [Do not Merge] from the title when your tests will be in the PR. |
@hovsepm , can you point me to a doc which explains how to run a specific test scenario. Eg. suppose I want to run only https://github.com/Azure/azure-powershell/blob/dev/src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/DiagnosticsExtensionTests.ps1 |
@NimishaS to run any specific test you will need to first find a corresponding C# Unit test that executes that script and run it with Xunit framework (usually it is much easier to do in Visual Studio). Line 24 in 3d52731
|
@hovsepm , we are done adding the specs. We are able to run the tests in |
Also Travis is failing for this PR but we are unable to see the details. |
@hovsepm , we are finally able to run the tests in
We have set the environment variables following https://github.com/Azure/azure-powershell/wiki/Microsoft-Azure-PowerShell-Developer-Guide#ad-scenario-tests. |
@hovsepm , any suggestions here? |
…_client_name are passed separately
7bd4854
to
7ba829b
Compare
@hovsepm we are waiting for your response to record test responses. Please refer my comment #1676 (comment). That's the problem we are currently stuck on. Rest everything is complete for this PR. |
@NimishaS the issue is that you did not include recorded mock recordings to the PR.
|
@NimishaS please see SessionRecords folder for an example. You will need to add your session record json file there in the correct folder, and add that file to Commands.Compute.Test.csproj. Make sure CopyToOutputDirectory setting will me set to "Always" in the csproj. |
$vmname = $vm.Name | ||
$version = "1210.12" | ||
$client_rb = ".\Templates\client.rb"; | ||
$validationPemFile = ".\Templates\tstorgnztn-validator.pem"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please align the white-spaces in this file.
@hovsepm , issue is that we aren't able to record specs. When we run the tests in
We get this error for all specs. We have tried setting the environment variables mentioned here https://github.com/Azure/azure-powershell/wiki/Microsoft-Azure-PowerShell-Developer-Guide#ad-scenario-tests |
@NimishaS You should set TEST_CSM_ORGID_AUTHENTICATION, as specified in the error message - if you specify SubscriptionId and Environment, you will be prompted for credentials during the test. |
@markcowl, TEST_CSM_ORGID_AUTHENTICATION is set. Still we are getting the same error. |
@NimishaS What help do you need to get these changes in? We will have to close this pull request soon, as it is quite out of date. |
@NimishaS closing this PR, as there has been no activity in 2 months. Open a new PR if you weant us to consider changes. |
CreateOrUpdateWithHttpMessagesAsync
Get-AzureRmVMChefExtension
Remove-AzureRmVMChefExtension
Testing is in progress