Skip to content

Clu test project and updates to clu-getstart.md #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 20, 2016

Conversation

BurtBiel
Copy link

Clu test project and updates to clu-getstart.md

@azurecla
Copy link

Hi @BurtBiel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (burtbiel). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@@ -1,35 +0,0 @@
using System;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was unused, so deleting it for now

@BurtBiel
Copy link
Author

Tests pass in VS and with dnx test

@@ -25,7 +25,7 @@ CLUPackages require some additional files to direct generation of indexing, and
| ------------- |:-------------:|
| CommandAssemblies | File name of cmdlets assembly(ies) |
| NounPrefix | ‘AzureRm’ The part of the cmdlet noun to remove in clu commands|
| NounFirst | if true, the verb comes at the end of the command (e.g. az resource get)|
| NounFirst | if true, the verb comes at the end of the command (e.g. az resourcemanager resource ls)|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BurtBiel this should be az resource ls

@BurtBiel
Copy link
Author

Addressed core review feedback

@BurtBiel
Copy link
Author

It looks like one of our dependencies was removed, so I updated the Microsoft.CLU.Run
"NuGet.Commands": "3.3.0-local-*", -> project.json: "NuGet.Commands": "3.3.0", then the build passed

@BurtBiel
Copy link
Author

@markcowl addressed code review feedback and updated a nugget package resource to get the build passing

markcowl added a commit that referenced this pull request Jan 20, 2016
Clu test project and updates to clu-getstart.md
@markcowl markcowl merged commit 71b6b5f into Azure:clu Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants