Skip to content

Az --help generator and fix bug on buildpackage.ps1 #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 29, 2016
Merged

Conversation

arroyc
Copy link

@arroyc arroyc commented Jan 21, 2016

No description provided.

@azurecla
Copy link

Hi @arroyc, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (arroyc). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@arroyc
Copy link
Author

arroyc commented Jan 21, 2016

we need to have a help file "az.hlp" for now in the drop/.../pkg directory to have that "az --help to work"

@@ -35,9 +35,9 @@ if ($packageId -ne "Microsoft.CLU.Commands")
{
$contentFileText += " <file src=""content\*.lx"" target=""content""/>`r`n"
$contentFileText += " <file src=""content\*xml"" target=""content""/>`r`n"
if (Test-Path "$packageSource\content\help")
if (Test-Path "$packageSource\content\content\help")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arroyc Why add another layer? We should just be searching in content/help

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to build it ... I don't see those help files getting copied to drop/... . I found out it's creating the help files in src\bin...\publish..\content\content\help. Me and Burt had this same issue. It was more like a fix than a intentional change. Can you please try the previous version of this script and see if that was able to copy the help files properly?

@markcowl
Copy link
Member

@azuresdkci retest this please

@@ -0,0 +1,4 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arroyc as we discussed yesterday Replace this please. with something like welcome to the azure management commands. Run 'azure help' to get a list of all commands."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl done ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markcowl .. I am working on the tests ...

@markcowl
Copy link
Member

@arroyc merging for now, but please file an item to add tests for the completion functionality

markcowl added a commit that referenced this pull request Jan 29, 2016
Az --help generator and fix bug on buildpackage.ps1
@markcowl markcowl merged commit ba04e09 into Azure:clu Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants