Skip to content

New-AzSshKey should log to Warning stream instead of console #16988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 8, 2022

Conversation

PalmEmanuel
Copy link
Contributor

@PalmEmanuel PalmEmanuel commented Feb 1, 2022

Description

New-AzSshKey should log to a stream that PowerShell understands, and not the console. The stream chosen in this PR is to change it to the Warning stream to be consistent with how the Az CLI outputs the same information.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • [/] If applicable, the changes made in the PR have proper test coverage
  • [/] For public API changes to cmdlets:
    • [/] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • [/] the markdown help files have been regenerated using the commands listed here

@ghost ghost added the customer-reported label Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Thank you for your contribution PalmEmanuel! We will review the pull request and get back to you soon.

@PalmEmanuel PalmEmanuel changed the title New-SshKey logs to Warning stream instead of console New-AzSshKey logs to Warning stream instead of console Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

CLA assistant check
All CLA requirements met.

@PalmEmanuel PalmEmanuel changed the title New-AzSshKey logs to Warning stream instead of console New-AzSshKey should log to Warning stream instead of console Feb 1, 2022
@PalmEmanuel PalmEmanuel marked this pull request as ready for review February 1, 2022 10:17
@wyunchi-ms
Copy link
Contributor

Please resolve the conflicts.

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@VeryEarly VeryEarly self-assigned this Feb 8, 2022
@VeryEarly VeryEarly merged commit bca8db5 into Azure:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants