Skip to content

Cover data plane cmdlets in Smoke test #17114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2022
Merged

Cover data plane cmdlets in Smoke test #17114

merged 3 commits into from
Feb 21, 2022

Conversation

lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented Feb 15, 2022 •
edited
Loading

Update RmCoreSmokeTest.ps1 file

#17066

dingmeng-xue
dingmeng-xue requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@dingmeng-xue dingmeng-xue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to use older pattern module name [comment]
if you add new property, you need to ensure test property should be shown on during test execution or when there is failure.

@VeryEarly VeryEarly self-assigned this Feb 17, 2022
@lijinpei2008
Copy link
Contributor Author

Consider to use older pattern if you add new property, you need to ensure test property should be shown on during test execution or when there is failure.module name [comment]

Done.

dingmeng-xue
dingmeng-xue reviewed Feb 18, 2022
View reviewed changes
tools/Test/SmokeTest/RmCoreSmokeTests.ps1 Outdated
Comment on lines 83 to 86
@{Name = "Az.Storage [ac MngmPlane]"; Command = {New-AzStorageAccount -Name $storageAccountName -SkuName Standard_LRS -Location westus -ResourceGroupName $resourceGroupName -ErrorAction Stop}},
@{Name = "Az.Storage [ac DataPlane]"; Command = {Get-Command New-AzStorageAccount -Name $storageAccountName -SkuName Standard_LRS -Location westus -ResourceGroupName $resourceGroupName -ErrorAction Stop}},
@{Name = "Az.Storage [ct MngmPlane]"; Command = {New-AzStorageContext -StorageAccountName $storageAccountName -StorageAccountKey 12345678 -ErrorAction Stop}},
@{Name = "Az.Storage [ct DataPlane]"; Command = {Get-Command New-AzStorageContext -StorageAccountName $storageAccountName -StorageAccountKey 12345678 -ErrorAction Stop}},
Copy link
Member

@dingmeng-xue dingmeng-xue Feb 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New-AzStorageAccount is management plane cmdlet.

Suggested change
@{Name = "Az.Storage [ac MngmPlane]"; Command = {New-AzStorageAccount -Name $storageAccountName -SkuName Standard_LRS -Location westus -ResourceGroupName $resourceGroupName -ErrorAction Stop}},
@{Name = "Az.Storage [ac DataPlane]"; Command = {Get-Command New-AzStorageAccount -Name $storageAccountName -SkuName Standard_LRS -Location westus -ResourceGroupName $resourceGroupName -ErrorAction Stop}},
@{Name = "Az.Storage [ct MngmPlane]"; Command = {New-AzStorageContext -StorageAccountName $storageAccountName -StorageAccountKey 12345678 -ErrorAction Stop}},
@{Name = "Az.Storage [ct DataPlane]"; Command = {Get-Command New-AzStorageContext -StorageAccountName $storageAccountName -StorageAccountKey 12345678 -ErrorAction Stop}},
@{Name = "Az.Storage [Management]"; Command = {New-AzStorageAccount -Name $storageAccountName -SkuName Standard_LRS -Location westus -ResourceGroupName $resourceGroupName -ErrorAction Stop}},
@{Name = "Az.Storage [Data]"; Command = {New-AzStorageContext -StorageAccountName $storageAccountName -StorageAccountKey 12345678 -ErrorAction Stop}},
@{Name = "Az.Storage [Data 1]"; Command = {Get-Command Get-AzStorageBlob -ErrorAction Stop}},

dingmeng-xue
dingmeng-xue reviewed Feb 18, 2022
View reviewed changes
tools/Test/SmokeTest/RmCoreSmokeTests.ps1 Outdated
@{Name = "Az.SignalR"; Command = {Get-AzSignalR -ErrorAction Stop}},
@{Name = "Az.Sql"; Command = {Get-AzSqlServer -ErrorAction Stop}},
@{Name = "Az.SqlVirtualMachine"; Command = {Get-AzSqlVM -ErrorAction Stop}},
@{Name = "Az.StreamAnalytics"; Command = {Get-AzStreamAnalyticsJob -ErrorAction Stop}},
@{Name = "Az.StorageSync"; Command = {Get-AzStorageSyncService -ErrorAction Stop}},
@{Name = "Az.Support"; Command = {Get-AzSupportTicket -ErrorAction Stop}},
@{Name = "Az.Resources [Tags]"; Command = {Get-AzTag -ErrorAction Stop}},
@{Name = "Az.Resources [DataPlane]"; Command = {Get-Command Get-AzAdGroup -ErrorAction Stop}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@{Name = "Az.Resources [DataPlane]"; Command = {Get-Command Get-AzAdGroup -ErrorAction Stop}},
@{Name = "Az.Resources [MSGraph]"; Command = {Get-AzAdGroup -First 1 -ErrorAction Stop}},

@dingmeng-xue
Copy link
Member

Please try it locally before PR creation.

@dingmeng-xue dingmeng-xue merged commit f3b9e1c into main Feb 21, 2022
@lijinpei2008 lijinpei2008 deleted the feature/smoketest branch February 24, 2022 07:32
@dingmeng-xue dingmeng-xue linked an issue Feb 28, 2022 that may be closed by this pull request
[Feature]: Cover data plane cmdlets in Smoke test #17066
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

Assignees

@VeryEarly VeryEarly

Labels
needs-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Cover data plane cmdlets in Smoke test
3 participants
@lijinpei2008 @dingmeng-xue @VeryEarly