Add AksTestRunner and replace TestController #17962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidai-msft
requested changes
Apr 24, 2022
| .WithNewRmModules (helper => new[] | ||
| { | ||
| helper.RMProfileModule, | ||
| helper.GetRMModulePath("AzureRM.Aks.psd1") |
There was a problem hiding this comment.
Update from AzureRM.Aks.psd1 to Az.Aks.psd1
| AzureSession.Instance.DataStore.WriteFile(Path.Combine(home, ".azure", "acsServicePrincipal.json"), jsonOutput); | ||
| } | ||
| } | ||
| ).WithManagementClients( |
There was a problem hiding this comment.
Remove the invocation of WithManagementClients()
| .Build(); | ||
| } | ||
|
|
||
| private static ContainerServiceClient GetContainerServiceClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
| { | ||
| return context.GetServiceClient<ContainerServiceClient>(); | ||
| } | ||
| private MicrosoftGraphClient GetGraphManagementClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
| { | ||
| return context.GetServiceClient<MicrosoftGraphClient>(); | ||
| } | ||
| private static AuthorizationManagementClient GetAuthorizationManagementClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
| { | ||
| return context.GetServiceClient<AuthorizationManagementClient>(); | ||
| } | ||
| private static ResourceManagementClient GetInternalResourceManagementClient(MockContext context) |
There was a problem hiding this comment.
This method definition is not necessary. Please remove it.
vidai-msft
requested changes
Apr 25, 2022
ziyuezh576
force-pushed
the
AksTestRunner
branch
from
2c8d703 to
098f4cd
Compare
ziyuezh576
force-pushed
the
AksTestRunner
branch
from
caecbf4 to
098f4cd
Compare
isra-fel
requested changes
Apr 25, 2022
| @@ -0,0 +1,87 @@ | |||
| using System; | |||
isra-fel
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added