Disable Set-AzureSqlServerCommunicationLink #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update semantics are not supported on server communication links
|
I would really like this to be in the next release for which we're a couple a days from the cutoff date. Can we please pull this in quicker? |
|
@adumitr this approach does not let users understand why the cmdlet was removed. It would be better to throw an exception with some meaningful explanation rather than just commenting out the cmdlet which is there for several releases. |
|
I see your point. We considered it, in this case we'd like for the cmdlet to not show up at all. It was never documented and it never worked before, update semantics are not allowed on the service side so the exceptions would come from there anyway. Let's merge as is |
|
Okay, done, can we merge it now? |
hovsepm
pushed a commit
that referenced
this pull request
Feb 24, 2016
Disable Set-AzureSqlServerCommunicationLink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update semantics are not supported on server communication links