Check fullSetParametersFile for null before attempting a Path.Combine

[eocrawford]

See title

[azuresdkci]

Can one of the admins verify this patch?

[hovsepm]

@azuresdkci add to whitelist

[hovsepm]

@eocrawford please fix build breaks

[eocrawford]

Hi, not sure what the issue is here or how to fix it. (My change contains a passing unit test.) I'm unable to access the Details URL (http://azuresdkci.cloudapp.net/job/powershell/4459/); fails with eocrawford is missing the Overall/Read permission. If you can grant that permission, I'll take a look at the details and see what I can do to fix the problem

[markcowl]

@eocrawford build failure, here are the errors from the log:

(CoreCompile target) -> 
17:16:42   Websites\PublishAzureWebsiteProjectTests.cs(25,53): error CS1525: Invalid expression term '[' [D:\workspace\powershell-2\src\ServiceManagement\Services\Commands.Test\Commands.Test.csproj]
17:16:42   Websites\PublishAzureWebsiteProjectTests.cs(25,54): error CS1003: Syntax error, ',' expected [D:\workspace\powershell-2\src\ServiceManagement\Services\Commands.Test\Commands.Test.csproj]
17:16:42   Websites\PublishAzureWebsiteProjectTests.cs(25,73): error CS1003: Syntax error, ',' expected [D:\workspace\powershell-2\src\ServiceManagement\Services\Commands.Test\Commands.Test.csproj]

[markcowl]

@eocrawford This is where the compilation issue is, according to the log.

I believe you use the same literal construction as a dictionary, i.e.:

var connectionStrings = new HashTable {
    {"DefaultConnection", "test-connection-string"}
};

[eocrawford]

I've moved the hashtable initialization after the declaration to match the existing syntax in other test cases.

[markcowl]

@azuresdkci retest this please

[hovsepm]

@azuresdkci retest this please

[markcowl]

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/620/ (soon)

[markcowl]

@eocrawford failure in the on demand run

[eocrawford]

I'm not able to view the results at http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/620/. How do I get permission? Alternately, you can paste the results here and I'll take a look.

[eocrawford]

I'm not able to repro the test failure locally and it happens outside the area I touched. Can we get a rerun?

[eocrawford]

@azuresdkci retest this please

[eocrawford]

@azuresdkci retest this please

[hovsepm]

on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/626/