Skip to content

Upgrade MSAL version #19726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Upgrade MSAL version #19726

merged 4 commits into from
Oct 6, 2022

Conversation

dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Oct 2, 2022

Description

Upgrade Microsoft.Identity.Client to 4.46.2 and Microsoft.Identity.Client.Extensions.Msal to 2.23.0
Add Microsoft.IdentityModel.Abstractions for .NET fraemwork because it is introduced by new version of Microsoft.Identity.Client

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@dingmeng-xue
Copy link
Member Author

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Oct 5, 2022

/azp where

@azure-pipelines
Copy link
Contributor

Azure DevOps orgs getting events for this repository:

@YanaXu
Copy link
Contributor

YanaXu commented Oct 5, 2022

/azp where

1 similar comment
@YanaXu
Copy link
Contributor

YanaXu commented Oct 5, 2022

/azp where

@azure-pipelines
Copy link
Contributor

Azure DevOps orgs getting events for this repository:

@YanaXu
Copy link
Contributor

YanaXu commented Oct 5, 2022

/azp list

@azure-pipelines
Copy link
Contributor

@dingmeng-xue dingmeng-xue marked this pull request as ready for review October 6, 2022 07:40
@wyunchi-ms wyunchi-ms merged commit b3659f7 into release-2022-10-12 Oct 6, 2022
@wyunchi-ms wyunchi-ms deleted the dixue/netcoreapp branch January 10, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants