Skip to content

Optimization of CI pipeline #19799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Oct 13, 2022

Description

  1. Save CI plan to artifacts to be consumpted by github bot.
  2. Reuse the artifacts saved by Build job to save the time of StaticAnalysis and Test.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@wyunchi-ms wyunchi-ms force-pushed the wyunchi/pipeline/artifacts-result branch from 1b972be to 76e9c6b Compare October 19, 2022 10:47
@wyunchi-ms wyunchi-ms changed the title draft Optimization of CI pipeline Oct 19, 2022
@wyunchi-ms wyunchi-ms marked this pull request as ready for review October 19, 2022 13:47
@dingmeng-xue
Copy link
Member

GenerateHelp is used by many place. You need to consider whether name should be revised. If yes, update all docs
https://github.com/Azure/azure-powershell/search?p=2&q=GenerateHelp

2. Reuse the artifacts from the previous build to save the time in StaticAnalysis and Test
@wyunchi-ms wyunchi-ms force-pushed the wyunchi/pipeline/artifacts-result branch from 5bf978b to 6d519ed Compare October 19, 2022 14:08
@VeryEarly VeryEarly self-assigned this Oct 20, 2022
@VeryEarly VeryEarly merged commit 3ab4313 into main Oct 20, 2022
@VeryEarly VeryEarly deleted the wyunchi/pipeline/artifacts-result branch October 20, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants