Skip to content

Add logic to support EventHub config #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2016
Merged

Conversation

yantang-msft
Copy link
Contributor

Add logics so user can enable MA to EventHub from powershell

@markcowl
Copy link
Member

tests?

@yantang-msft
Copy link
Contributor Author

Hi Mark,

IIRC, today is the Code Complete date for powershell? What’s the exact time?
I’m adding test cases, but we want to get this change in for the April release, so we don’t want to miss the last chance of merging.

Thanks!
Yanming

From: Mark Cowlishaw [mailto:[email protected]]
Sent: Wednesday, March 23, 2016 12:30 AM
To: Azure/azure-powershell [email protected]
Cc: Yanming Tang [email protected]
Subject: Re: [azure-powershell] Add logic to support EventHub config (#1981)

tests?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//pull/1981#issuecomment-200227946

@markcowl
Copy link
Member

@yantang-msft if you guys sign off on the functionality, it is ok to add the tests later this week. But please file an issue for this in GitHub and refer to it here.

@markcowl
Copy link
Member

{
public class DiagnosticsHelperTest
{
[Fact]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be attributed as check-in tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see BVT defined in this project which looks closer.
Here is what marked for DSC extension, [Trait(Category.Functional, Category.BVT)]. Should I follow this attribute or add "CheckIn" in the category?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl Attribute added. See if it's correct.

@markcowl
Copy link
Member

@yantang-msft
Copy link
Contributor Author

@markcowl The failed test case is irrelevant to this change, it will also fail before any of my commits.
However, I tested it will pass with current dev branch (and after merging my changes as well). So I assume there is some test framework change which fixed this issue, it's just that I branched before this fix.

@hovsepm
Copy link
Contributor

hovsepm commented Mar 24, 2016

@markcowl markcowl merged commit 7d405d8 into Azure:dev Mar 24, 2016
@yantang-msft yantang-msft deleted the EventHub branch April 19, 2016 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants