-
Notifications
You must be signed in to change notification settings - Fork 4k
Add logic to support EventHub config #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests? |
Hi Mark, IIRC, today is the Code Complete date for powershell? What’s the exact time? Thanks! From: Mark Cowlishaw [mailto:[email protected]] tests? — |
@yantang-msft if you guys sign off on the functionality, it is ok to add the tests later this week. But please file an issue for this in GitHub and refer to it here. |
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/618/ |
{ | ||
public class DiagnosticsHelperTest | ||
{ | ||
[Fact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be attributed as check-in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see BVT defined in this project which looks closer.
Here is what marked for DSC extension, [Trait(Category.Functional, Category.BVT)]. Should I follow this attribute or add "CheckIn" in the category?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl Attribute added. See if it's correct.
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/625/ |
@markcowl The failed test case is irrelevant to this change, it will also fail before any of my commits. |
Add logics so user can enable MA to EventHub from powershell