-
Notifications
You must be signed in to change notification settings - Fork 4k
[Do not merge]: Co-existence API and stats API #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dihan0604 This PR is failing due to static analysis issues (1) you added 2 cmdlets without online help; (2) [non-critical] there is now an unused assembly reference in commands.network to the storage management library You will need to resolve these issues |
@azuresdkci add to whitelist |
On demand job: http://azuresdkci.cloudapp.net/job/powershell-demand/626/ |
On demand job pass. |
This change has been built on top off #1986 |
why are we not adding tests for the new cmdlets |
We have not release the new API at our service side. (Gateway manager). |
@dihan0604
|
@dihan0604 missing header in:
and
|
in src\ResourceManager\Network\Commands.Network\Commands.Network.csproj
commented lines |
in src\ResourceManager\Network\Commands.Network.Test\ScenarioTests\ExpressRouteCircuitTests.ps1 file remove commented lines:
|
Have addressed comments |
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/636/ |
closing as this was just merged into the release branch |
No description provided.