Skip to content

[Do not merge]: Co-existence API and stats API #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

dihan0604
Copy link
Contributor

No description provided.

@dihan0604
Copy link
Contributor Author

@markcowl
Copy link
Member

@dihan0604 This PR is failing due to static analysis issues (1) you added 2 cmdlets without online help; (2) [non-critical] there is now an unused assembly reference in commands.network to the storage management library

You will need to resolve these issues

@markcowl
Copy link
Member

@azuresdkci add to whitelist

@dihan0604
Copy link
Contributor Author

@dihan0604
Copy link
Contributor Author

On demand job pass.

@DeepakRajendranMsft
Copy link
Contributor

This change has been built on top off #1986

@DeepakRajendranMsft
Copy link
Contributor

why are we not adding tests for the new cmdlets

@dihan0604
Copy link
Contributor Author

We have not release the new API at our service side. (Gateway manager).
We do not want to miss this PS release. So we decide to add test later once service side code is updated

@hovsepm
Copy link
Contributor

hovsepm commented Mar 24, 2016

@dihan0604
You are missing licence header in all files under :

src\ResourceManager\Network\Commands.Network\ExpressRouteCircuit\Stats\

@hovsepm
Copy link
Contributor

hovsepm commented Mar 24, 2016

@dihan0604 missing header in:

src\ResourceManager\Network\Commands.Network\Models\PSExpressRouteCircuitRoutesTableSummary.cs

and

src\ResourceManager\Network\Commands.Network\Models\PSExpressRouteCircuitStats.cs

@hovsepm
Copy link
Contributor

hovsepm commented Mar 24, 2016

in src\ResourceManager\Network\Commands.Network\Commands.Network.csproj
remove

 <!--Compile Include="ExpressRouteCircuit\Stats\GetAzureExpressRouteRouteTableSummaryCommand.cs" /--> 
...
    <!--Compile Include="ExpressRouteCircuit\Stats\GetAzureExpressRouteARPTableCommand.cs" /-->
    <!--Compile Include="ExpressRouteCircuit\Stats\GetAzureExpressRouteRouteTableCommand.cs" /-->
    <!--Compile Include="ExpressRouteCircuit\Stats\GetAzureExpressRouteStatsCommand.cs" /-->

commented lines

@hovsepm
Copy link
Contributor

hovsepm commented Mar 24, 2016

in src\ResourceManager\Network\Commands.Network.Test\ScenarioTests\ExpressRouteCircuitTests.ps1 file remove commented lines:


      #$getCircuit = Set-AzureRmExpressRouteCircuit -ExpressRouteCircuit $getCircuit -AllowClassicOperations $true
      #Assert-AreEqual $true $getCircuit.AllowClassicOperations

@dihan0604
Copy link
Contributor Author

Have addressed comments

@markcowl
Copy link
Member

@markcowl markcowl changed the title Co-existence API and stats API [Do not merge]: Co-existence API and stats API Mar 24, 2016
@markcowl
Copy link
Member

closing as this was just merged into the release branch

@markcowl markcowl closed this Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants