Skip to content

Creating Cmdlets for Alert Rules (Insights) #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Creating Cmdlets for Alert Rules (Insights) #199

wants to merge 3 commits into from

Conversation

gucalder
Copy link
Contributor

No description provided.

@azurecla
Copy link

Hi @gucalder, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (gucalder). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@ogail
Copy link
Contributor

ogail commented Feb 27, 2015

@gucalder please add at least one mocked scenario test associated with these cmdlets

amarzavery
amarzavery reviewed Mar 2, 2015
View reviewed changes
src/ResourceManager/Insights/Commands.Insights/Alerts/AddAlertRuleCommand.cs
};
break;
default:
throw new NotSupportedException(string.Format(CultureInfo.InvariantCulture, "Rule type {0} is not supported", this.RuleType));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the text message in Resources.Resx and use it from there

@amarzavery
Copy link
Contributor

@gucalder - Please address the review comments so that we can merge the PR and make it a part of this PS release.

@markcowl
Copy link
Member

markcowl commented Mar 3, 2015

@gucalder Please resolve issues and retarget at the release-0.8.15 branch

@markcowl markcowl closed this Mar 3, 2015
AzureRT referenced this pull request in AzureRT/azure-powershell Nov 19, 2015
@huangpf
Merge pull request #199 from Azure/dev
a0ca367 
.
markcowl pushed a commit that referenced this pull request Apr 28, 2016
@pragrawa
Merge pull request #199 from MabOneSdk/pragrawa-dev1
208bac0 
Vault Context cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gucalder @azurecla @ogail @amarzavery @markcowl