Skip to content

Support publishing package with xml files (#19787) #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Support publishing package with xml files (#19787) #20023

merged 3 commits into from
Nov 4, 2022

Conversation

BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Nov 4, 2022

Description

The publishing process removes xml files from nuget packages. Adding a parameter to allow us to specify whether removing xml files. Tested by https://dev.azure.com/azclitools/release/_build/results?buildId=13181&view=results and https://dev.azure.com/azclitools/release/_build/results?buildId=13183&view=results

Comparing two artifacts, no difference except xml files added

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@BethanyZhou BethanyZhou marked this pull request as draft November 4, 2022 03:13
@BethanyZhou BethanyZhou marked this pull request as ready for review November 4, 2022 05:36
@wyunchi-ms wyunchi-ms merged commit ce611c1 into main Nov 4, 2022
@BethanyZhou BethanyZhou deleted the bez/xml branch November 11, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants