Skip to content

Typo Fix #20087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Typo Fix #20087

merged 1 commit into from
Nov 18, 2022

Conversation

thwpike
Copy link
Contributor

@thwpike thwpike commented Nov 11, 2022

Changed 'mmutability' to 'immutability'

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Changed 'mmutability' to 'immutability'
@ghost ghost added the customer-reported label Nov 11, 2022
@ghost
Copy link

ghost commented Nov 11, 2022

Thank you for your contribution thwpike! We will review the pull request and get back to you soon.

@Nickcandy
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@Nickcandy
Copy link
Contributor

@BethanyZhou Please help me check why this ci failed. Should it be force-merged?

@BethanyZhou
Copy link
Contributor

Hi @Nickcandy , I raised a PR to fix CI please help review it: #20156.

After that PR get merged, please retrigger this CI and I think issues would be gone.

@Nickcandy
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Nov 17, 2022
@Nickcandy
Copy link
Contributor

/azp run azure-powershell - powershell-core (Analyze windows)

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@Nickcandy
Copy link
Contributor

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@BethanyZhou
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@BethanyZhou BethanyZhou merged commit 79080ce into Azure:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants