Skip to content

[PS->Portal] Provide resource type of top 10 services used in Portal for SDK based cmdlets #20102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 16, 2022

Conversation

Alex-wdy
Copy link
Contributor

@Alex-wdy Alex-wdy commented Nov 14, 2022

Description

Provide resource type of top 10 services used in Portal for SDK based cmdlets.

microsoft.insights/components
microsoft.keyvault/vaults
microsoft.network/virtualnetworks
microsoft.sql/servers
microsoft.datafactory/factories
microsoft.network/networksecuritygroups
microsoft.network/networkinterfaces
microsoft.documentdb/databaseaccounts
microsoft.compute/disks
microsoft.network/applicationgateways

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@Alex-wdy Alex-wdy changed the title Alex/ux [PS->Portal] Provide resource type of top 10 services used in Portal for SDK based cmdlets Nov 14, 2022
@Alex-wdy Alex-wdy marked this pull request as ready for review November 14, 2022 06:48
@wyunchi-ms wyunchi-ms self-assigned this Nov 14, 2022
@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit 4fcab27 into main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants