Skip to content

[AKS] support Mode in 'New-AzAksNodePool' and 'Update-AzAksNodePool' #20194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

YanaXu
Copy link
Contributor

@YanaXu YanaXu commented Nov 22, 2022

Description

Support Mode in 'New-AzAksNodePool' and 'Update-AzAksNodePool'.
After this solution:

  • New-AzAksCluster
    • Support NodePoolMode.
    • Since AzPS now only supports creating one nodepool when creating a aks cluster, and AKS requires at least one nodepool is system mode, New-AzAksCluster only supports NodePoolMode=System, which is the default value if it's not set.
  • Set-AzAksCluster
    • Support NodePoolMode.
    • It's only valid when there is more than 1 pool. It requires NodeName in this case.
  • New-AzAksNodePool
    • Support Mode.
  • Update-AzAksNodePool
    • Support Mode.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@YanaXu YanaXu requested a review from wyunchi-ms November 22, 2022 05:57
@wyunchi-ms wyunchi-ms merged commit 74f47f7 into Azure:main Nov 22, 2022
@wyunchi-ms
Copy link
Contributor

Set-AzAksCluster and New-AzAksCluster is not updated in this PR.

@YanaXu YanaXu deleted the yanxu/aks_param branch November 22, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants