Skip to content

Merging Network-2022-07-01 changes into main branch #20223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 24, 2022
Merged

Merging Network-2022-07-01 changes into main branch #20223

merged 8 commits into from
Nov 24, 2022

Conversation

htippanaboya
Copy link
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

htippanaboya and others added 8 commits November 18, 2022 08:15
…r CustomBlockResponseFeature (#19971)

* Powershell changes for waf custom block response feature

* Added test record

* Update ChangeLog.md

* Updating sdk version for 2022-07-01

* Updated tests

* Update ChangeLog.md

Co-authored-by: Akshay Murali <[email protected]>
Co-authored-by: Adishree Mazumder <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
* init commit

* add help, move to singular not plural

* fix help

* upadte changelog

* try to resolve conflict

* init commit

* get help file

Co-authored-by: Alon Pelled <[email protected]>
Merging Network 2022 07 01 into main
@htippanaboya htippanaboya changed the title Merging Network-2022-07-01 changes into main brnach Merging Network-2022-07-01 changes into main branch Nov 23, 2022
@Nickcandy
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Nov 24, 2022
@Nickcandy Nickcandy merged commit 20786e6 into Azure:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge 🚫 Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. Waiting for CI :shipit:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants