Skip to content

[Storage] Support Planned and Unplanned failoverType in Storage account failover #20311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

yifanz0
Copy link
Contributor

@yifanz0 yifanz0 commented Nov 29, 2022

Description

Support "Planned" option for failoverType for Invoke-AzStorageAccountFailover

Unit tests will be added later

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@yifanz0 yifanz0 changed the title [Storage] Support Planned failoverType in Storage account failover [Storage] Support Planned and Unplanned failoverType in Storage account failover Nov 29, 2022
@Nickcandy
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).


## INPUTS

### System.String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line changed by generate help tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is.

@msJinLei msJinLei added the needs-author-feedback More information is needed from author to address the issue. label Nov 30, 2022
@msJinLei msJinLei assigned msJinLei, yifso and yifanz0 and unassigned yifso Nov 30, 2022
@msJinLei msJinLei merged commit 5325a73 into Azure:Az.Storage-preview Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-author-feedback More information is needed from author to address the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants