Skip to content

Add new examples #20361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Add new examples #20361

merged 2 commits into from
Dec 7, 2022

Conversation

timwarner-msft
Copy link
Contributor

Added examples to the New-AzPolicyAssignment and New-AzPolicyDefinition help files to show customers how to get the reader-friendly DisplayName property from those objects.

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@timwarner-msft
Copy link
Contributor Author

cc: @shanhix1, @mikefrobbins

Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use full parameter names instead of positional parameters. Couple of minor style issues, but otherwise looks good.

@msJinLei
Copy link
Contributor

msJinLei commented Dec 7, 2022

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei
Copy link
Contributor

msJinLei commented Dec 7, 2022

@mikefrobbins could you help to see whether all of your comments are addressed? thanks

@mikefrobbins
Copy link
Contributor

@msJinLei All of my comments have been addressed and this PR is ready to be merged. #sign-off

Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msJinLei msJinLei merged commit d126c2e into Azure:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants