-
Notifications
You must be signed in to change notification settings - Fork 4k
Add new examples #20361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new examples #20361
Conversation
cc: @shanhix1, @mikefrobbins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use full parameter names instead of positional parameters. Couple of minor style issues, but otherwise looks good.
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
@mikefrobbins could you help to see whether all of your comments are addressed? thanks |
@msJinLei All of my comments have been addressed and this PR is ready to be merged. #sign-off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added examples to the
New-AzPolicyAssignment
andNew-AzPolicyDefinition
help files to show customers how to get the reader-friendlyDisplayName
property from those objects.Description
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.