-
Notifications
You must be signed in to change notification settings - Fork 4k
[AzureLoadTesting] New Module, commands for Azure Load Testing #20385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updated tests
You should record json for your tests |
@msJinLei the entire test suite is in Az.LoadTesting.Tests.ps1 file |
Yes, please remove them |
@msJinLei could you please help with why the CI pipelines are failing in tests, though they are succeeding in local? |
@venkatr21 If your PR is ready, please remove the |
@msJinLei Our service GA date is on end of Jan 2023, we would like to release the PowerShell module only around the GA date (mid to end Jan) and not anytime soon, but we would like to wrap up with the review and be ready for the release then. Please let us know if merging the PR automatically releases the PowerShell module for our service (if yes, we would like to merge this PR only around our GA date, else if merging the PR does not release the PowerShell module, we would like to merge this now) |
@venkatr21 I will set the target release date |
@msJinLei I have removed the do not merge label |
Description
New RP onboarding to Azure PowerShell
Module: Az.LoadTesting
Command:
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.Open questions
Our service GA date is on end of Jan 2023, we would like to release the PowerShell module only around the GA date (mid to end Jan) and not anytime soon, but we would like to wrap up with the review and be ready for the release then.
We would need guidance on the tabular format output of the commands. Currently we show only 4 properties as mentioned below. We would like to know if we can show more properties on the tabular output, since we see that most RPs show only minimal essential fields on the tabular output.