Initial release of Azure RemoteApp cmdlet #204

yadavbdev · 2015-03-01T00:26:11Z

No description provided.

- Updated Stream Analytics SDK reference to the 0.16.0-preview version which corresponds to the 2015-01-01-preview Stream Analytics Service API Version - Integrated PowerShell cmdlets with the new features of the latest SDK. Most PowerShell cmdlets were already integrated since the new properties can be specified in the json file parameter. The most notable change was the addition of the OutputStartMode and OutputStartTime parameters in the StartAzureStreamAnalyticsJob cmdlet. - Re-recorded the tests and updated the session records.

Update Stream Analytics PowerShell To Use Latest SDK

…p SDK

Included Amarpreet's changes for the new features

…nto dev Conflicts: src/ResourceManager/StreamAnalytics/Commands.StreamAnalytics.Test/packages.config

…was created by the backend (simplevnet-*)

…xxx synchronous.

… robdev

…nto dev

… the upload script and adding feature check

hovsepm · 2015-03-02T19:57:16Z

...erviceManagement/RemoteApp/Commands.RemoteApp/Vnet/GetAzureRemoteAppVpnDeviceConfigScript.cs

+                WriteObject(response.ConfigScript);
+            }
+        }
+


extra line break

…lets not working

ogail · 2015-03-02T21:52:46Z

src/ServiceManagement/RemoteApp/Commands.RemoteApp.Tests/VNet/RemoteAppVNet.cs

+    using System.Linq;
+    using VisualStudio.TestTools.UnitTesting;
+
+    [TestClass]


Please refine from using MSTest and convert the tests to xUnit

ogail · 2015-03-02T21:55:27Z

The cmdlets file should not have business logic, instead create a RemoteAppCleint which encapsulates that.
Add mocked scenario tests

… merg_from_others

markcowl · 2015-03-02T22:56:52Z

@yadavbdev Please remove the MSTest tests and commit to adding equivalent, passing xunit tests in this sprint. Also, please respond to code comments and fix the build breaks.

relmer · 2015-03-02T23:08:53Z

Are you asking for those to be fixed in 45 or 46? We’ll definitely commit to converting them to xunit for 46.

From: Mark Cowlishaw [mailto:[email protected]]
Sent: Monday, March 2, 2015 2:57 PM
To: Azure/azure-powershell
Cc: Rob Elmer
Subject: Re: [azure-powershell] Initial release of Azure RemoteApp cmdlet (#204)

@yadavbdevhttps://github.com/yadavbdev Please remove the MSTest tests and commit to adding equivalent, passing xunit tests in this sprint. Also, please respond to code comments and fix the build breaks.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/204#issuecomment-76845637.

…Automation library

markcowl · 2015-03-02T23:41:38Z

@yadavbdev remove the mstest tests in 45 (i.e. before check in) and respond to the other review feedback. In sprint 46, add back the tests as xunit tests

markcowl · 2015-03-03T05:13:55Z

src/ServiceManagement/RemoteApp/Commands.RemoteApp/packages.config

+<packages>
+  <package id="Hyak.Common" version="1.0.2" targetFramework="net45" />
+  <package id="Microsoft.Azure.Common" version="2.0.2" targetFramework="net45" />
+  <package id="Microsoft.Azure.Common.Authentication" version="1.0.10-preview" targetFramework="net45" />


This needs to be updated to match the Azure.Common.Authentication version used in all the other cmdlets

markcowl · 2015-03-03T05:32:53Z

@yadavbdev There are a couple ofpackage version and depdnecy version issues which will cause problems with your install. I also notice that this contains no installer changes, so that your cmdlet dlls will not be included in the installer. See tools\BuildInstaller.ps1 for commands to update the installer. Finally, there is no online help. See https://github.com/Azure/adx-documentation-pr/blob/master/CLIs/PowerShell/Tools/cmdlet-help-doc-editor.md for details on this.

markcowl · 2015-03-03T05:36:48Z

src/ServiceManagement/RemoteApp/Commands.RemoteApp/Commands.RemoteApp.csproj

+    </Reference>
+    <Reference Include="Microsoft.IdentityModel.Clients.ActiveDirectory">
+      <SpecificVersion>False</SpecificVersion>
+      <HintPath>..\..\..\packages\Microsoft.IdentityModel.Clients.ActiveDirectory.3.0.110281957-alpha\lib\net45\Microsoft.IdentityModel.Clients.ActiveDirectory.dll</HintPath>


Also a major vewrsion > all other cmdlets

markcowl · 2015-03-03T06:08:20Z

@yadavbdev Please fix issues and retarget at the release branch (release-0.8.15)

Dev

Added logger wrapper and minor fixes in policy

atpham256 and others added 30 commits February 20, 2015 15:14

Merge pull request Azure#185 from atpham256/master

07830b6

Update Stream Analytics PowerShell To Use Latest SDK

Initial version of the Azure RemoteApp PowerShell cmdlet

3ef3a17

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

782014a

Changed to use the Context from Azure Authentication

64f6321

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

28715bd

Adding RemoteApp projects in to the .sln

fe60f9f

Updated RemoteApp project to use the public version of Azure RemoteAp…

b8e838d

…p SDK

Merge branch 'using_public_sdk' into dev

e495a49

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

2de5272

Upgrading to use Azure RemoteApp v1.0.7

07e643c

Updated to use the Azure RemoteApp v1.0.7

0ec01db

Included Amarpreet's changes for the new features

Merge branch 'dev' of https://github.com/yadavbdev/azure-powershell i…

b166d38

…nto dev Conflicts: src/ResourceManager/StreamAnalytics/Commands.StreamAnalytics.Test/packages.config

Fixing the CI build break

35aa503

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

312f697

Bug 1796479:OneSDK: Address feedback from Azure PS team

09e51ec

Bug 1827560:*Get-AzureRemoteAppCollection should not show vnet if it …

1f51213

…was created by the backend (simplevnet-*)

Bug 1856319:$ Remove Get-AzureRemoteAppUploadScript

f19825b

Bug 1856290:Remove Get-AzureRemoteAppResetVpnSharedKey -- make Reset-…

5e53e38

…xxx synchronous.

Bug 1856407:$Set-AzureRemoteAppCollection -- remove OU

3fe6eac

Ignoring all the failing tests for now, will revisit later

575a09b

Merge branch 'bugfix' into dev

97788a2

Merge branch 'dev' of https://github.com/relmer/azure-powershell into…

d48983c

… robdev

Parameter help message updated to include wild card support.

c7f0c4d

Bug 1856505:$Vnet cmdlets: param should be VNetName, not VnetName.

ac94a29

Fixed the potential null ref issue

d0f46c3

Merge branch 'dev' of https://github.com/yadavbdev/azure-powershell i…

6f7ae0c

…nto dev

Bug 1857745:New-AzureRemoteAppTemplateImage is not catching errors in…

a1e3ac5

… the upload script and adding feature check

Bug 1856575:*Some cmdlets aren't showing all params in get-help

88966d4

getting region from VNet

d8de3f1

hovsepm reviewed Mar 2, 2015
View reviewed changes

yadavbdev and others added 2 commits March 2, 2015 12:09

Changing Region -> Location and BillingPlan -> Plan

0d2384d

BUG 1879333:Mohoro: Gold image import from Azure IAAS - OneSDK PS cmd…

094692d

…lets not working

ogail reviewed Mar 2, 2015
View reviewed changes

yadavbdev added 3 commits March 2, 2015 13:57

Updated based on the Azure CR feedback

11ee869

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

37633af

Merge branch 'dev' of https://github.com/amarsi/azure-powershell into…

fff91f6

… merg_from_others

Removing the MS Test cases from the build

bc68d11

Removing the referece to the absolute binary for a System.Management.…

f0925a0

…Automation library

markcowl reviewed Mar 3, 2015
View reviewed changes

markcowl closed this Mar 3, 2015

huangpf referenced this pull request in AzureRT/azure-powershell Dec 13, 2015

Merge pull request #204 from huangpf/dev

b4f2c97

Dev

markcowl pushed a commit that referenced this pull request Apr 28, 2016

Merge pull request #204 from MabOneSdk/dev1-sudreddy

530d150

Added logger wrapper and minor fixes in policy

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Initial release of Azure RemoteApp cmdlet #204

Initial release of Azure RemoteApp cmdlet #204

Uh oh!

yadavbdev commented Mar 1, 2015

Uh oh!

hovsepm Mar 2, 2015

Uh oh!

ogail Mar 2, 2015

Uh oh!

ogail commented Mar 2, 2015

Uh oh!

markcowl commented Mar 2, 2015

Uh oh!

relmer commented Mar 2, 2015

Uh oh!

markcowl commented Mar 2, 2015

Uh oh!

markcowl Mar 3, 2015

Uh oh!

markcowl commented Mar 3, 2015

Uh oh!

markcowl Mar 3, 2015

Uh oh!

markcowl commented Mar 3, 2015

Uh oh!

Uh oh!

Initial release of Azure RemoteApp cmdlet #204

Initial release of Azure RemoteApp cmdlet #204

Uh oh!

Conversation

yadavbdev commented Mar 1, 2015

Uh oh!

hovsepm Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

ogail Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

ogail commented Mar 2, 2015

Uh oh!

markcowl commented Mar 2, 2015

Uh oh!

relmer commented Mar 2, 2015

Uh oh!

markcowl commented Mar 2, 2015

Uh oh!

markcowl Mar 3, 2015

Choose a reason for hiding this comment

Uh oh!

markcowl commented Mar 3, 2015

Uh oh!

markcowl Mar 3, 2015

Choose a reason for hiding this comment

Uh oh!

markcowl commented Mar 3, 2015

Uh oh!

Uh oh!